Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

Problem

Dependency update from dotnet/arcade introduced stricter code analysis rules, causing Linux build failures:

  • IDE0044: Field not marked readonly in MockInstallerFactory.cs
  • IDE0048: Missing parentheses for clarity in XunitLoggerProvider.cs, CliHostTemplateDataLoader.cs, CliHostDataProducer.cs

Solution

  • Updated Microsoft.DotNet.Arcade.Sdk from 8.0.0-beta.25563.4 to 8.0.0-beta.25577.1
  • Fixed code analysis violations:
    • Made _factory field readonly
    • Added parentheses around null-coalescing right-hand expressions:
      // Before
      file?.GetDisplayPath() ?? templateInfo.MountPointUri + templateInfo.HostConfigPlace
      // After  
      file?.GetDisplayPath() ?? (templateInfo.MountPointUri + templateInfo.HostConfigPlace)

Checks:

  • Added unit tests

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Dec 2, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • go.microsoft.com
    • Triggering command: /usr/share/dotnet/dotnet /usr/share/dotnet/dotnet exec --depsfile /home/REDACTED/work/templating/templating/artifacts/bin/Microsoft.TemplateSearch.Common.UnitTests/Debug/net8.0/Microsoft.TemplateSearch.Common.UnitTests.deps.json --runtimeconfig /home/REDACTED/work/templating/templating/artifacts/bin/Microsoft.TemplateSearch.Common.UnitTests/Debug/net8.0/Microsoft.TemplateSearch.Common.UnitTests.runtimeconfig.json /home/REDACTED/.nuget/packages/xunit.REDACTED.console/2.4.2/tools/netcoreapp2.0/xunit.console.dll /home/REDACTED/work/templating/templating/artifacts/bin/Microsoft.TemplateSearch.Common.UnitTests/Debug/net8.0/Microsoft.TemplateSearch.Common.UnitTests.dll -noautoreporters -xml /home/REDACTED/work/templating/templating/artifacts/TestResults/Debug/Microsoft.TemplateSearch.Common.UnitTests_net8.0_x64.xml -html /home/REDACTED/work/templating/templating/artifacts/TestResults/Debug/Microsoft.TemplateSearch.Common.UnitTests_net8.0_x64.html (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Update dependencies from dotnet/arcade [release/8.0.1xx] Update dependencies from dotnet/arcade Dec 2, 2025
Copilot AI requested a review from marcpopMSFT December 2, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants