Skip to content

Implement uniform exceptions classes across model providers #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plpxsk wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Implement uniform exceptions classes across model providers #1823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e081ecb
Implement uniform exceptions classes across providers
plpxsk Mar 4, 2026
f0f7be4
Guard provider exception handlers against non-SDK errors
plpxsk Mar 12, 2026
0d51124
Remove unused APIError imports
plpxsk Mar 12, 2026
bf6ef20
Remove bad dependency
plpxsk Mar 12, 2026
baa24b7
Let local runtimes propagate native errors
plpxsk Mar 12, 2026
a1caa9e
Add comments that local runtimes bypass exceptions normalization
plpxsk Mar 13, 2026
6c1dcb6
Implement exceptions for chunk streams also
plpxsk Mar 13, 2026
2bb60de
Update docs
plpxsk Mar 18, 2026
4f915bf
Consolidate tests
plpxsk Mar 18, 2026
e9ac356
Use new BadRequestError for schema error
plpxsk Mar 19, 2026
aba41f0
Use new GenerationError for refusals
plpxsk Mar 19, 2026
159880c
Improve docs
plpxsk Mar 19, 2026
f5deb34
Reconcile tests
plpxsk Mar 19, 2026
3de42f0
Fix: add LM Studio to local models list
plpxsk Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Implement exceptions for chunk streams also
  • Loading branch information
@plpxsk @RobinPicard
plpxsk authored and RobinPicard committed Mar 26, 2026
commit 6c1dcb6b6e4d7b554f8b98c8f503e271ef8fd061
17 changes: 11 additions & 6 deletions outlines/models/anthropic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,12 +259,17 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream:
if (
chunk.type == "content_block_delta"
and chunk.delta.type == "text_delta"
):
yield chunk.delta.text
try:
for chunk in stream:
if (
chunk.type == "content_block_delta"
and chunk.delta.type == "text_delta"
):
yield chunk.delta.text
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


def from_anthropic(
Expand Down
11 changes: 8 additions & 3 deletions outlines/models/gemini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,14 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream:
if hasattr(chunk, "text") and chunk.text:
yield chunk.text
try:
for chunk in stream:
if hasattr(chunk, "text") and chunk.text:
yield chunk.text
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


def from_gemini(client: "Client", model_name: Optional[str] = None) -> Gemini:
Expand Down
42 changes: 26 additions & 16 deletions outlines/models/mistral.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,13 +404,18 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream:
if (
hasattr(chunk, "data")
and chunk.data.choices
and chunk.data.choices[0].delta.content is not None
):
yield chunk.data.choices[0].delta.content
try:
for chunk in stream:
if (
hasattr(chunk, "data")
and chunk.data.choices
and chunk.data.choices[0].delta.content is not None
):
yield chunk.data.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


class AsyncMistral(AsyncModel):
Expand Down Expand Up @@ -545,15 +550,20 @@ async def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

async for chunk in response:
if (
hasattr(chunk, "data")
and chunk.data.choices
and len(chunk.data.choices) > 0
and hasattr(chunk.data.choices[0], "delta")
and chunk.data.choices[0].delta.content is not None
):
yield chunk.data.choices[0].delta.content
try:
async for chunk in response:
if (
hasattr(chunk, "data")
and chunk.data.choices
and len(chunk.data.choices) > 0
and hasattr(chunk.data.choices[0], "delta")
and chunk.data.choices[0].delta.content is not None
):
yield chunk.data.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


def from_mistral(
Expand Down
18 changes: 14 additions & 4 deletions outlines/models/ollama.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,13 @@ def generate_stream(
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e
for chunk in response:
yield chunk.message.content
try:
for chunk in response:
yield chunk.message.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


class AsyncOllama(AsyncModel):
Expand Down Expand Up @@ -376,8 +381,13 @@ async def generate_stream( # type: ignore
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e
async for chunk in stream:
yield chunk.message.content
try:
async for chunk in stream:
yield chunk.message.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


def from_ollama(
Expand Down
22 changes: 16 additions & 6 deletions outlines/models/openai.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,9 +360,14 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream:
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
try:
for chunk in stream:
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


class AsyncOpenAI(AsyncModel):
Expand Down Expand Up @@ -516,9 +521,14 @@ async def generate_stream( # type: ignore
raise
raise normalize_provider_exception(e, PROVIDER) from e

async for chunk in stream:
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
try:
async for chunk in stream:
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e


def from_openai(
Expand Down
22 changes: 16 additions & 6 deletions outlines/models/sglang.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,9 +205,14 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
try:
for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e

def _build_client_args(
self,
Expand Down Expand Up @@ -358,9 +363,14 @@ async def generate_stream( # type: ignore
raise
raise normalize_provider_exception(e, PROVIDER) from e

async for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
try:
async for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e

def _build_client_args(
self,
Expand Down
18 changes: 14 additions & 4 deletions outlines/models/tgi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,13 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream: # pragma: no cover
yield chunk
try:
for chunk in stream: # pragma: no cover
yield chunk
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e

def _build_client_args(
self,
Expand Down Expand Up @@ -320,8 +325,13 @@ async def generate_stream( # type: ignore
raise
raise normalize_provider_exception(e, PROVIDER) from e

async for chunk in stream: # pragma: no cover
yield chunk
try:
async for chunk in stream: # pragma: no cover
yield chunk
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e

def _build_client_args(
self,
Expand Down
22 changes: 16 additions & 6 deletions outlines/models/vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,14 @@ def generate_stream(
raise
raise normalize_provider_exception(e, PROVIDER) from e

for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
try:
for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e

def _build_client_args(
self,
Expand Down Expand Up @@ -339,9 +344,14 @@ async def generate_stream( # type: ignore
raise
raise normalize_provider_exception(e, PROVIDER) from e

async for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
try:
async for chunk in stream: # pragma: no cover
if chunk.choices and chunk.choices[0].delta.content is not None:
yield chunk.choices[0].delta.content
except Exception as e:
if not is_provider_exception(e, PROVIDER):
raise
raise normalize_provider_exception(e, PROVIDER) from e

def _build_client_args(
self,
Expand Down