Skip to content

Implement uniform exceptions classes across model providers #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
plpxsk wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Implement uniform exceptions classes across model providers #1823

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e081ecb
Implement uniform exceptions classes across providers
plpxsk Mar 4, 2026
f0f7be4
Guard provider exception handlers against non-SDK errors
plpxsk Mar 12, 2026
0d51124
Remove unused APIError imports
plpxsk Mar 12, 2026
bf6ef20
Remove bad dependency
plpxsk Mar 12, 2026
baa24b7
Let local runtimes propagate native errors
plpxsk Mar 12, 2026
a1caa9e
Add comments that local runtimes bypass exceptions normalization
plpxsk Mar 13, 2026
6c1dcb6
Implement exceptions for chunk streams also
plpxsk Mar 13, 2026
2bb60de
Update docs
plpxsk Mar 18, 2026
4f915bf
Consolidate tests
plpxsk Mar 18, 2026
e9ac356
Use new BadRequestError for schema error
plpxsk Mar 19, 2026
aba41f0
Use new GenerationError for refusals
plpxsk Mar 19, 2026
159880c
Improve docs
plpxsk Mar 19, 2026
f5deb34
Reconcile tests
plpxsk Mar 19, 2026
3de42f0
Fix: add LM Studio to local models list
plpxsk Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove bad dependency
  • Loading branch information
@plpxsk @RobinPicard
plpxsk authored and RobinPicard committed Mar 26, 2026
commit bf6ef200deb10e9cb3f26c5e629822a69aef8b3a
3 changes: 0 additions & 3 deletions outlines/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,6 @@ def _build_exception_map(provider: str) -> dict[type, type[APIError]]:

if provider == "gemini":
import httpx
import aiohttp
from google.genai import errors as genai_errors
return {
genai_errors.ServerError: ServerError,
Expand All @@ -283,8 +282,6 @@ def _build_exception_map(provider: str) -> dict[type, type[APIError]]:
# normalize_provider_exception, which maps it to the right subclass.
httpx.TimeoutException: APITimeoutError,
httpx.ConnectError: APIConnectionError,
aiohttp.ServerTimeoutError: APITimeoutError,
aiohttp.ClientConnectorError: APIConnectionError,
}

if provider == "ollama":
Expand Down
9 changes: 0 additions & 9 deletions tests/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,6 @@ class TestGeminiExceptionMap:
@pytest.fixture(autouse=True)
def _require_gemini(self):
pytest.importorskip("google.genai")
pytest.importorskip("aiohttp")

def _check(self, sdk_exc_cls, expected_outlines_cls):
result = normalize_provider_exception(Mock(spec=sdk_exc_cls), "gemini")
Expand All @@ -473,14 +472,6 @@ def test_httpx_connect_error(self):
import httpx
self._check(httpx.ConnectError, APIConnectionError)

def test_aiohttp_server_timeout(self):
import aiohttp
self._check(aiohttp.ServerTimeoutError, APITimeoutError)

def test_aiohttp_client_connector_error(self):
import aiohttp
self._check(aiohttp.ClientConnectorError, APIConnectionError)

def test_client_error_status_code_fallback(self):
from google.genai import errors as genai_errors
mock_exc = Mock(spec=genai_errors.ClientError)
Expand Down