Skip to content

Conversation

va3093
Copy link
Contributor

@va3093 va3093 commented Aug 14, 2025

Motivation

When looking through the docs I noticed the following typo.

image

I then wondered how many typos there are in our docs.

So I wrote (who am I kidding AI wrote) this script:

find . -type f -name "*.mdx" -print0 | while IFS= read -r -d '' file; do
  echo "Processing: $file"
  ~/Code/system/claude_bedrock.sh -p "fix typos in this file $file" --permission-mode acceptEdits < "$file"
done

and a few hours later was left with this 😬.

CleanShot 2025-08-14 at 17 40 50@2x

TODO: I have not done a check for false positives but I suspect there are some.

"fmt"
"strings"
"net/http"
"io/ioutil"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol. it would be amazing if this was a legit bug.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol this actually seems accurate i think just "io" is what it should be

@karimhass karimhass marked this pull request as ready for review August 14, 2025 17:32
Copy link
Contributor

@karimhass karimhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried reviewing all the files, but theres a repetitive pattern that I am seeing. Some files don't need the changing and others do. I provided comments on the ones we can keep as is, which follows a common pattern. Hope this review helps!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this stays as 10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reviewer's comment is incorrect. In Go, the url.Values.Set()method signature isSet(key, value string), which requires both parameters to be strings. The change from 10to"10"was actually a bug fix, not a typo. The code withparams.Set("limit", 10) would not compile in Go.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as this one stays as 1000

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it should stay as query_parameters =

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would not be valid typescript though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keep it as onchain

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks accurate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep as is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep as is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep these as is

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep as is

@va3093 va3093 mentioned this pull request Aug 15, 2025
@va3093 va3093 closed this Aug 15, 2025
@va3093
Copy link
Contributor Author

va3093 commented Aug 15, 2025

closing in favour of smaller prs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants