-
-
Notifications
You must be signed in to change notification settings - Fork 10
eXist 5.3.0 compatible version #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you, @chakl and @line-o! Is there a reason the PR is against the eXist-5.3.0 branch instead of master? Could you confirm what the minimum eXist compatible version is now? Also, once this is merged and published, do you recommend that we pull the "v5.3.0" version from the public repo? I recall this was known to be incompatible with eXist 5.x, despite its dependency declarations. http://exist-db.org/exist/apps/public-repo/packages/expath-crypto-exist-lib.html?eXist-db-min-version=4.4.0 |
|
Version 5.3.0 of the crypto lib was, despite not being built from this repository, overwritten with a package that was version 1.0.0 with its version bumped. |
| <attributes> | ||
| <attribute name="optional" value="true"/> | ||
| <attribute name="maven.pomderived" value="true"/> | ||
| <attribute name="test" value="true"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eclipse Project files should not be in SCM. Can you remove them and also add appropriate rules to your .gitignore please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really understand why this is worthy to block the merge of this PR.
As only one line was added (by @claudius108) it is clear that this file was in version control before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this commit 2a0cf88
|
This PR needs to be closed as its target branch is master and not existdb 5.3.0 |
|
Superseded by #37 |
crypto lib compatible with the coming version of eXist-db (5.3.0)
This version is built on top of the community project base but includes the latest changes and fixes made by @claudius108
Thanks to @chakl for tying up the loose ends.