Skip to content

Conversation

@line-o
Copy link
Member

@line-o line-o commented Jun 2, 2021

crypto lib compatible with the coming version of eXist-db (5.3.0)

This version is built on top of the community project base but includes the latest changes and fixes made by @claudius108

Thanks to @chakl for tying up the loose ends.

@line-o line-o requested a review from a team June 2, 2021 17:36
@joewiz
Copy link
Member

joewiz commented Jun 2, 2021

Thank you, @chakl and @line-o!

Is there a reason the PR is against the eXist-5.3.0 branch instead of master?

Could you confirm what the minimum eXist compatible version is now?

Also, once this is merged and published, do you recommend that we pull the "v5.3.0" version from the public repo? I recall this was known to be incompatible with eXist 5.x, despite its dependency declarations. http://exist-db.org/exist/apps/public-repo/packages/expath-crypto-exist-lib.html?eXist-db-min-version=4.4.0

@line-o
Copy link
Member Author

line-o commented Jun 3, 2021

Version 5.3.0 of the crypto lib was, despite not being built from this repository, overwritten with a package that was version 1.0.0 with its version bumped.
Pulling this package from the public repository was vetoed from the community.
The new version will therefore be 6.0.0 and will have a minimum processor dependency of 5.3.0

<attributes>
<attribute name="optional" value="true"/>
<attribute name="maven.pomderived" value="true"/>
<attribute name="test" value="true"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eclipse Project files should not be in SCM. Can you remove them and also add appropriate rules to your .gitignore please?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not really understand why this is worthy to block the merge of this PR.
As only one line was added (by @claudius108) it is clear that this file was in version control before.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this commit 2a0cf88

@joewiz joewiz changed the title compatible version eXist 5.3.0 compatible version Jun 7, 2021
@line-o
Copy link
Member Author

line-o commented Jun 11, 2021

This PR needs to be closed as its target branch is master and not existdb 5.3.0

@line-o
Copy link
Member Author

line-o commented Jun 11, 2021

Superseded by #37

@line-o line-o closed this Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants