Update for the latest version of eXist #11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Agree. |
Member
|
Is this PR backward-compatible with eXist 4.x? (The package currently declares version compatibility with eXist 4.4 or later.) |
Contributor
Author
|
@joewiz I don't think so |
Member
|
@adamretter Great. I'd like to be able to give this PR a quick test but am unable to build the project. Adam or @claudius108 Could you please let me know the steps you use to build it? |
Collaborator
|
Run "mvn clean package" |
Member
|
@claudius108 Thanks for that hint! Unfortunately, the build encounters an error. Here is my console output for the master branch: Here is the output for this PR's branch: This is with Maven 3.6.1 on macOS 10.14.6. Do you have any suggestions? |
Collaborator
|
Why do you changed the POM file to use ro.kuberam.expath.exist:base:pom:1.6.0-SNAPSHOT? |
Member
|
I didn’t change the POM file... I just checked out this PR’s branch and the master branch. |
Collaborator
|
Use version 1.5.5 for parent, and it will work: <groupId>ro.kuberam.expath.exist</groupId>
<artifactId>base</artifactId>
<version>1.5.5</version> |
Member
|
@claudius108 Thanks! But from a fresh clone of the repository, checked out to master, and your change to pom.xml in place, I still get an error: Doing the same with this PR's branch, I get: |
Collaborator
|
You could use version 1.5 for ro.kuberam.libs.java:crypto. This is the latest I published in the maven repo. |
Member
|
@claudius108 Thanks, I think we're getting closer, but even with the changes you suggested to pom.xml, I'm getting compilation errors when building the master branch: The changes to
|
Collaborator
|
Hi,
I cannot test in order to fix, as my internet connection is broken. I hope
it will be repaired very soon.
Claudius
…On Jul 25, 2019 6:17 PM, "Joe Wicentowski" ***@***.***> wrote:
@claudius108 <https://github.com/claudius108> Thanks, I think we're
getting closer, but even with the changes you suggested to pom.xml, I'm
getting compilation errors when building the master branch:
e$ mvn clean package
[INFO] Scanning for projects...
[INFO]
[INFO] -------------------< ro.kuberam.expath.exist:crypto >-------------------
[INFO] Building eXist-db EXPath Cryptographic library 0.8.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ crypto ---
[INFO] Deleting /Users/joe/workspace/crypto-exist-java-lib/target
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-maven) @ crypto ---
[INFO]
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ crypto ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 1 resource
[INFO]
[INFO] --- maven-compiler-plugin:3.1:compile (default-compile) @ crypto ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 10 source files to /Users/joe/workspace/crypto-exist-java-lib/target/classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java: /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java uses or overrides a deprecated API.
[WARNING] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java: Recompile with -Xlint:deprecation for details.
[WARNING] Some messages have been simplified; recompile with -Xdiags:verbose to get full output
[INFO] 3 warnings
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/encrypt/EncryptionFunctions.java:[128,75] incompatible types: byte[] cannot be converted to java.io.InputStream
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/encrypt/EncryptionFunctions.java:[158,75] incompatible types: byte[] cannot be converted to java.io.InputStream
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java:[132,52] constructor NodeInputStream in class org.exist.validation.internal.node.NodeInputStream cannot be applied to given types;
required: org.exist.Database,org.exist.storage.serializers.Serializer,org.exist.xquery.value.NodeValue
found: org.exist.storage.serializers.Serializer,org.exist.xquery.value.NodeValue
reason: actual and formal argument lists differ in length
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java:[263,70] cannot find symbol
symbol: method getDescription()
location: variable DENIED_KEYSTORE of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java:[269,59] cannot find symbol
symbol: method getDescription()
location: variable KEYSTORE_URL of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/EXpathCryptoException.java:[33,80] cannot find symbol
symbol: method getDescription()
location: variable cryptoError of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/ExpathCryptoErrorCode.java:[14,44] cannot find symbol
symbol: method getCode()
location: variable cryptoError of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/ExpathCryptoErrorCode.java:[14,139] cannot find symbol
symbol: method getDescription()
location: variable cryptoError of type ro.kuberam.libs.java.crypto.CryptoError
[INFO] 8 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1.413 s
[INFO] Finished at: 2019-07-25T11:13:18-04:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:compile (default-compile) on project crypto: Compilation failure: Compilation failure:
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/encrypt/EncryptionFunctions.java:[128,75] incompatible types: byte[] cannot be converted to java.io.InputStream
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/encrypt/EncryptionFunctions.java:[158,75] incompatible types: byte[] cannot be converted to java.io.InputStream
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java:[132,52] constructor NodeInputStream in class org.exist.validation.internal.node.NodeInputStream cannot be applied to given types;
[ERROR] required: org.exist.Database,org.exist.storage.serializers.Serializer,org.exist.xquery.value.NodeValue
[ERROR] found: org.exist.storage.serializers.Serializer,org.exist.xquery.value.NodeValue
[ERROR] reason: actual and formal argument lists differ in length
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java:[263,70] cannot find symbol
[ERROR] symbol: method getDescription()
[ERROR] location: variable DENIED_KEYSTORE of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/digitalSignature/GenerateSignatureFunction.java:[269,59] cannot find symbol
[ERROR] symbol: method getDescription()
[ERROR] location: variable KEYSTORE_URL of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/EXpathCryptoException.java:[33,80] cannot find symbol
[ERROR] symbol: method getDescription()
[ERROR] location: variable cryptoError of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/ExpathCryptoErrorCode.java:[14,44] cannot find symbol
[ERROR] symbol: method getCode()
[ERROR] location: variable cryptoError of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] /Users/joe/workspace/crypto-exist-java-lib/src/main/java/org/expath/exist/crypto/ExpathCryptoErrorCode.java:[14,139] cannot find symbol
[ERROR] symbol: method getDescription()
[ERROR] location: variable cryptoError of type ro.kuberam.libs.java.crypto.CryptoError
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
The changes to pom.xml were:
-
Change line 10:
- <version>1.6.0-SNAPSHOT</version>
+ <version>1.5.5</version>
-
Change line 47:
- <crypto.java.lib.version>1.7.0-SNAPSHOT</crypto.java.lib.version>
+ <crypto.java.lib.version>1.5</crypto.java.lib.version>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANKHHR2QRG2POO7JLRTDTTQBG7XZANCNFSM4G42FYDQ>
.
|
dizzzz
approved these changes
Jul 29, 2019
claudius108
approved these changes
Aug 2, 2019
Collaborator
|
The below pom, along with the change @adamretter proposes with this PR, will fix the build. ` ` |
adamretter
force-pushed
the
hotfix/exist-update
branch
from
99167be to
65ba670
Compare
Contributor
Author
|
@claudius108 @joewiz Okay I have taken a look... First thing we need to do is get these two PRs merged to the base library:
Once that is done, we then secondly need to get a release of crypto-java-lib @claudius108 Can you help with the above please? |
adamretter
force-pushed
the
hotfix/exist-update
branch
from
65ba670 to
5954270
Compare
Collaborator
|
Hi, After this PR is approved, two steps are to be taken (I can do this):
|
adamretter
force-pushed
the
hotfix/exist-update
branch
from
5954270 to
d84075a
Compare
adamretter
force-pushed
the
hotfix/exist-update
branch
from
d84075a to
10a45b9
Compare
Collaborator
|
Great, and congratulations for v. 5.0! |
Member
|
@claudius108 Forgive me if I made a mistake with 21526a4, but I was seeking to get the repo and this PR updated and ready to incorporate the same fix applied in eXist-db/exist@ad0bed1. However, I wasn't successful at finding the same references to |
Collaborator
|
Hi, I made the xar for eXist 5.3.0. Is anyone willing to test it? I was not able to upload it to the eXist public repo. I can send it by email. Thanks, |
Member
|
That’s great, Claudius, thanks! I’d be happy to test it. |
Member
|
@claudius108 I've successfully installed the xar that you sent me, and confirmed that it doesn't suffer from the bug reported at eXist-db/exist#3540. Looking forward to your PR! Also, I assume that after your PR has been merged this one could be closed? |
Collaborator
|
Hi, There is no need for PR, as I made a new branch for eXist 5.3.0, and also renumbered the module version to be synchronized with eXist. I was not able again to upload the xar in the public repo. Claudius |
Member
|
@claudius108 I see there is a new release available in the eXist public repo - thank you! Could you please point me to the updated source code? |
Member
|
@claudius108 The new xar declares that it is compatible with eXist 4.4.0. Is it backward compatible that far, or does it require eXist 5.3.0 (as the package's version number would suggest)? |
Collaborator
|
Hi,
I want also to thank the person who published the v. 5.3.0. of this module
in eXist's public repo, as I got an error while trying to do it.
The update source code is at
https://github.com/claudius108/crypto-exist-java-lib/tree/eXist-5.3.0.
There the dependency is for eXist 5.3.0.
As one can see, I synchronized the module's version with the eXist's
version, and I will make a new branch for each eXist and module version.
Best regards,
Claudius
…On Sat, 17 Oct 2020 at 22:44, Joe Wicentowski ***@***.***> wrote:
@claudius108 <https://github.com/claudius108> The new xar declares that
it is compatible with eXist 4.4.0. Is it backward compatible that far, or
does it require eXist 5.3.0 (as the package's version number would suggest)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANKHHQLICZMJY4RWM4NG4DSLHXYDANCNFSM4G42FYDQ>
.
|
Member
|
@claudius108 Could you please submit a PR so the latest code is in this repository? Then we can close this PR, and community maintenance and discussion of the codebase can resume here. Thank you so much, Claudius! Regarding branches for 4.x and 5.x development, you might consult monex's example:
The analogous changes for the crypto module would be similar. You already jumped to v5.3.0 for the eXist 5.x version, so maintenance of the eXist 5.x branch might well take place in the master branch. And the eXist 4.x branch could take place in a "crypto-1.x" branch. What do you think of this? By the way, does 5.3.0 of crypto module break only for eXist 4.x or also eXist 5.x before eXist 5.3.0? |
Member
|
Multiple projects depending on the crypto lib break when installed on exist 5.3.0-SNAPSHOT |
Collaborator
|
I did not added the module
xmldb:///db/system/repo/jwt-1.0.1/test/jwt-spec.xqm
to the xar.
…On Mon, 16 Nov 2020 at 14:13, Juri Leino ***@***.***> wrote:
Multiple projects depending on the crypto lib break when installed on
exist 5.3.0-SNAPSHOT
Error: It is a static error if multiple functions declared or imported by a module have the number of arguments and their expanded QNames are equal (as defined by the eq operator). Error while loading module xmldb:///db/system/repo/jwt-1.0.1/test/jwt-spec.xqm: error found while loading module jwt: Error while loading module : Prolog has more than one imported module that defines the function: {http://expath.org/ns/crypto}generate-signature#7
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANKHHRZ5EDYAOV73T7ZYUDSQEJPHANCNFSM4G42FYDQ>
.
|
Member
|
This PR is superseded by #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.