-
-
Notifications
You must be signed in to change notification settings - Fork 19
Prepare monex 1.0.0 release and new monex-1.x branch #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a2c7227. # Conflicts: # expath-pkg.xml.tmpl
|
I have now added 4.6.1 to the Nexus repo. |
|
@joewiz If you want to change |
|
@joewiz exist should now properly treat max-min ranges as inclusive on both 4.x and 5.x |
duncdrum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this line
to :
<dependency processor="http://exist-db.org" semver-min="${min.version}" semver-max="${max.version}"/>|
@joewiz without changing the |
|
@duncdrum Got it! I've now changed |
DO NOT MERGE until issue below is resolved.
Update (2019-04-22): Thanks to @duncdrum, this PR is ok to merge now.
As proposed in #73 (comment), this PR establishes a new "monex-1.x" branch targeting eXist 4.x by reverting the change that assumed the eXist 5.x JMX format. This will allow us to publish at least one more release of monex, containing valuable fixes submitted since monex 0.9.17, for users of eXist 4.x.
While the result builds, it has a problem: the
expath-pkg.xmlproduced by the build routine needs to have asemver-max=4.99.0declaration in order to prevent installation of this package on eXist 5.x, i.e., to limit installation to eXist 4.x systems. However, maven produces the following:So this PR should not be merged until we find some way to get maven to output
semver-max=4.99.0for the eXist dependency.Really, of course, we should specify both
semver-max=4.99.0AND asemver-min=3.7.0-SNAPSHOT(that was the last value before 0.9.17 when we bumped the requirement to 5.0.0, but, unfortunately, until the bug I reported that prevents concurrent use ofsemver-minandsemver-maxis solved (see also fgeorges/expath-pkg-java#8), we can only use one of these declarations, so we must choose the most important one,semver-max.A side issue: I had expected to be able to specify eXist 4.6.1 in pom.xml, but I got this error during the
mvn package, so I switched it to 4.6.0:This suggests the eXist 4.6.1 artifacts aren't in the maven repository used by the monex pom.
But again, ultimately, we need to be able to produce
semver-max=4.99.0.