Skip to content

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5#2329

Merged
terrancedejesus merged 2 commits intomainfrom
version-lock-f5c992b6
Sep 26, 2022
Merged

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5#2329
terrancedejesus merged 2 commits intomainfrom
version-lock-f5c992b6

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5.

  • Autogenerated from job lock-versions: pr.

"rule_name": "Google Drive Ownership Transferred via Google Workspace",
"sha256": "f8e05498e63a3fb10621fd91713a7f0995aaf07a9eb6fd5ef73b62c7a81458f6",
"type": "query",
"version": 1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we leave rule versions at 1? Or during the fork, it auto-bumps the first previous entry by 100?

@terrancedejesus
Copy link
Copy Markdown
Contributor

terrancedejesus commented Sep 26, 2022

Locked version updates look fine. Checks made.

  • No double/triple bumps were included
  • If version 100 to 101, check the previous entry and ensure the buffer space made sense
  • Verified rules with Version: 1 were in the list of new rules listed in E2E testing scope
  • Verified K8s rules had intended minimum stack version
  • Verified any integration rules that were updated but not included in E2E testing scope were ML or threat indicator matching rules

Copy link
Copy Markdown
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrancedejesus terrancedejesus added the trade-artifacts Issues related to TRADE artifact building and releasing label Sep 26, 2022
@terrancedejesus terrancedejesus merged commit 1b6355e into main Sep 26, 2022
@terrancedejesus terrancedejesus deleted the version-lock-f5c992b6 branch September 26, 2022 18:24
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
protectionsmachine pushed a commit that referenced this pull request Sep 26, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/deprecated_rules.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 1b6355e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto trade-artifacts Issues related to TRADE artifact building and releasing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants