Skip to content

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5#2332

Merged
terrancedejesus merged 3 commits intomainfrom
version-lock-4abd3b83
Sep 29, 2022
Merged

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5#2332
terrancedejesus merged 3 commits intomainfrom
version-lock-4abd3b83

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5.

  • Autogenerated from job lock-versions: pr.

@terrancedejesus terrancedejesus self-requested a review September 29, 2022 14:32
@terrancedejesus terrancedejesus added v8.5.0 trade-artifacts Issues related to TRADE artifact building and releasing labels Sep 29, 2022
@terrancedejesus
Copy link
Copy Markdown
Contributor

terrancedejesus commented Sep 29, 2022

This is the second locked versions PR for the 8.5 release. Typically we lock once and work from that PR's merge commit to keep the detection rules is a static state as we release updates to Kibana and the pre-built rules integration package.

Why we locked again - After our initial lock and Kibana rule updates, we merged a PR to re-factor the related_integrations field value at build time to make it more resilient, add unit testing and address an expectation from the Kibana side for the version where we can add ^. During the merge, backporting failed at the 8.3 branch as a result of a version comparison bug in integrations.py, a separate PR was made and a solution provided for this. Since this ultimately adjusts ALL integration rules, they will be considered "dirty" during the package building and thus version will be bumped by 1.

To avoid version collisions and thus Kibana not understanding that updates are present during the next 8.6 release we needed to lock versions again. When checking the file adjustments, all rules that are "integration" rules will receive version bumps and are expected.

Copy link
Copy Markdown
Contributor

@terrancedejesus terrancedejesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The biggest check I wanted to ensure, based on the timing, was rule version and SHA256 diffs to integration rules, which seems to be the case.

Typical checks:

  • No double/triple/etc. version bumps
  • For each version bump, the SHA256 changed
  • For new rules in 8.5, they went from 1-2 as expected if an integration rule

Copy link
Copy Markdown
Contributor

@Mikaayenson Mikaayenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terrancedejesus terrancedejesus merged commit 05b715f into main Sep 29, 2022
@terrancedejesus terrancedejesus deleted the version-lock-4abd3b83 branch September 29, 2022 15:19
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
protectionsmachine pushed a commit that referenced this pull request Sep 29, 2022
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5

* Update detection_rules/etc/version.lock.json

* Update detection_rules/etc/version.lock.json

Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com>
Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com>

(cherry picked from commit 05b715f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport: auto trade-artifacts Issues related to TRADE artifact building and releasing v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants