Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5#2332
Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5#2332terrancedejesus merged 3 commits intomainfrom
Conversation
|
This is the second locked versions PR for the Why we locked again - After our initial lock and Kibana rule updates, we merged a PR to re-factor the related_integrations field value at build time to make it more resilient, add unit testing and address an expectation from the Kibana side for the version where we can add To avoid version collisions and thus Kibana not understanding that updates are present during the next |
terrancedejesus
left a comment
There was a problem hiding this comment.
LGTM. The biggest check I wanted to ensure, based on the timing, was rule version and SHA256 diffs to integration rules, which seems to be the case.
Typical checks:
- No double/triple/etc. version bumps
- For each version bump, the SHA256 changed
- For new rules in 8.5, they went from 1-2 as expected if an integration rule
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
* Locked versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5 * Update detection_rules/etc/version.lock.json * Update detection_rules/etc/version.lock.json Co-authored-by: terrancedejesus <terrancedejesus@users.noreply.github.com> Co-authored-by: Terrance DeJesus <99630311+terrancedejesus@users.noreply.github.com> (cherry picked from commit 05b715f)
Lock versions for releases: 7.16,8.0,8.1,8.2,8.3,8.4,8.5.
lock-versions: pr.