-
Notifications
You must be signed in to change notification settings - Fork 129
Conditional subobjects based on package version #2911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
teresaromero
merged 13 commits into
elastic:main
from
teresaromero:2832-mappings-subobjects
Sep 18, 2025
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
95d84fa
add support for version-based question prompts in data stream creation
teresaromero 092a91c
Update cmd/create_data_stream.go
teresaromero 6401c45
extract survey question logic into a separate function and add tests
teresaromero 4a0836c
add tests for createDataStreamDescriptorFromAnswers handling of Subob…
teresaromero b2d9ecc
add copyright notice to create_data_stream_test.go
teresaromero 4bcc828
Apply suggestion from @mrodm
teresaromero e4891f6
Apply suggestion from @mrodm
teresaromero 3e68e2e
Apply suggestion from @mrodm
teresaromero a9a124f
Apply suggestion from @mrodm
teresaromero 4621f9a
Apply suggestion from @mrodm
teresaromero 21a3eb4
Apply suggestion from @mrodm
teresaromero 2682da9
Add missing require import in create_data_stream_test.go
teresaromero b9ec1f0
Fix assertion for subobjects true case
teresaromero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add tests for createDataStreamDescriptorFromAnswers handling of Subob…
…jects based on spec version
- Loading branch information
commit 4a0836c554e0120587fda4b7fffb9615c544987b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.