Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests for createDataStreamDescriptorFromAnswers handling of Subob…
…jects based on spec version
  • Loading branch information
teresaromero committed Sep 16, 2025
commit 4a0836c554e0120587fda4b7fffb9615c544987b
48 changes: 48 additions & 0 deletions cmd/create_data_stream_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,51 @@ func TestGetSurveyQuestionsForVersion_AboveSemver3_2_0(t *testing.T) {
assert.Equal(t, "subobjects", questions[3].Name)
assert.IsType(t, &survey.Confirm{}, questions[3].Prompt)
}
func TestCreateDataStreamDescriptorFromAnswers_SubobjectsFalseForSpecVersionBelow3_2_0(t *testing.T) {
specVersion := semver.MustParse("3.1.0")
answers := newDataStreamAnswers{
Name: "test_stream",
Title: "Test Stream",
Type: "logs",
Subobjects: false,
}
descriptor := createDataStreamDescriptorFromAnswers(answers, "/tmp/package", specVersion)

assert.Equal(t, "test_stream", descriptor.Manifest.Name)
assert.Equal(t, "Test Stream", descriptor.Manifest.Title)
assert.Equal(t, "logs", descriptor.Manifest.Type)
assert.Equal(t, "/tmp/package", descriptor.PackageRoot)
assert.Nil(t, descriptor.Manifest.Elasticsearch)
}

func TestCreateDataStreamDescriptorFromAnswers_SubobjectsFalseForSpecVersionGTE3_2_0(t *testing.T) {
specVersion := semver.MustParse("3.2.0")
answers := newDataStreamAnswers{
Name: "test_stream",
Title: "Test Stream",
Type: "logs",
Subobjects: false,
}
descriptor := createDataStreamDescriptorFromAnswers(answers, "/tmp/package", specVersion)

assert.NotNil(t, descriptor.Manifest.Elasticsearch)
assert.NotNil(t, descriptor.Manifest.Elasticsearch.IndexTemplate)
assert.NotNil(t, descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings)
assert.False(t, descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings.Subobjects)
}

func TestCreateDataStreamDescriptorFromAnswers_SubobjectsTrueForSpecVersionGTE3_2_0(t *testing.T) {
specVersion := semver.MustParse("3.2.0")
answers := newDataStreamAnswers{
Name: "test_stream",
Title: "Test Stream",
Type: "logs",
Subobjects: true,
}
descriptor := createDataStreamDescriptorFromAnswers(answers, "/tmp/package", specVersion)

// Should not set Elasticsearch.IndexTemplate.Mappings.Subobjects
if descriptor.Manifest.Elasticsearch != nil && descriptor.Manifest.Elasticsearch.IndexTemplate != nil && descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings != nil {
assert.NotEqual(t, false, descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings.Subobjects)
}
}