Skip to content

Conditional subobjects based on package version #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 18, 2025
Merged

Conditional subobjects based on package version #2911

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
95d84fa
add support for version-based question prompts in data stream creation
teresaromero Sep 15, 2025
092a91c
Update cmd/create_data_stream.go
teresaromero Sep 16, 2025
6401c45
extract survey question logic into a separate function and add tests
teresaromero Sep 16, 2025
4a0836c
add tests for createDataStreamDescriptorFromAnswers handling of Subob…
teresaromero Sep 16, 2025
b2d9ecc
add copyright notice to create_data_stream_test.go
teresaromero Sep 16, 2025
4bcc828
Apply suggestion from @mrodm
teresaromero Sep 16, 2025
e4891f6
Apply suggestion from @mrodm
teresaromero Sep 16, 2025
3e68e2e
Apply suggestion from @mrodm
teresaromero Sep 16, 2025
a9a124f
Apply suggestion from @mrodm
teresaromero Sep 16, 2025
4621f9a
Apply suggestion from @mrodm
teresaromero Sep 16, 2025
21a3eb4
Apply suggestion from @mrodm
teresaromero Sep 16, 2025
2682da9
Add missing require import in create_data_stream_test.go
teresaromero Sep 16, 2025
b9ec1f0
Fix assertion for subobjects true case
teresaromero Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestion from @mrodm 
Co-authored-by: Mario Rodriguez Molins <[email protected]>
  • Loading branch information
@teresaromero @mrodm
teresaromero and mrodm authored Sep 16, 2025
commit 4bcc8283811f5398c88cf09367a10f38daf8b981
8 changes: 4 additions & 4 deletions cmd/create_data_stream_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ func TestCreateDataStreamDescriptorFromAnswers_SubobjectsTrueForSpecVersionGTE3_
}
descriptor := createDataStreamDescriptorFromAnswers(answers, "/tmp/package", specVersion)

// Should not set Elasticsearch.IndexTemplate.Mappings.Subobjects
if descriptor.Manifest.Elasticsearch != nil && descriptor.Manifest.Elasticsearch.IndexTemplate != nil && descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings != nil {
assert.NotEqual(t, false, descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings.Subobjects)
}
require.NotNil(t, descriptor.Manifest.Elasticsearch)
require.NotNil(t, descriptor.Manifest.Elasticsearch.IndexTemplate)
require.NotNil(t, descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings)
assert.False(t, descriptor.Manifest.Elasticsearch.IndexTemplate.Mappings.Subobjects)
}