Skip to content

Fix/source enabled #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 9, 2018
Merged

Fix/source enabled #3015

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0108522
SourceEnabled() used to take string[] which adheres to the spec but s…
Mpdreamz Jan 8, 2018
927e3df
Generated request parameters value types should be nullable to reflec…
Mpdreamz Jan 8, 2018
376d883
generated request parameters on descriptors that take a value type sh…
Mpdreamz Jan 8, 2018
8a7dfbe
reran code generation after rebase
Mpdreamz Jan 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Generated request parameters value types should be nullable to reflec… 
…t their absence on the querystring
  • Loading branch information
@Mpdreamz
Mpdreamz committed Jan 9, 2018
commit 927e3df17b120b932e06570ffbadc87113fb14fd
16 changes: 13 additions & 3 deletions src/CodeGeneration/ApiGenerator/Domain/ApiQueryParameters.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ public class ApiQueryParameters
public string Obsolete { get; set; }
public IEnumerable<string> Options { get; set; }



public string CsharpType(string paramName)
{
switch (this.Type)
Expand Down Expand Up @@ -86,10 +84,22 @@ public string HighLevelType(string paramName)
return csharpType;
}
}
private static string NullableCsharpType(string fieldType)
{
switch (fieldType)
{
case "bool": return "bool?";
case "integer": return "int?";
case "double": return "double?";
case "long": return "long?";
default:
return fieldType;
}
}

public Func<string, string, string, string, string> Generator { get; set; } =
(fieldType, mm, original, setter) =>
$"public {fieldType} {mm} {{ get {{ return Q<{fieldType}>(\"{original}\"); }} set {{ Q(\"{original}\", {setter}); }} }}";
$"public {NullableCsharpType(fieldType)} {mm} {{ get {{ return Q<{NullableCsharpType(fieldType)}>(\"{original}\"); }} set {{ Q(\"{original}\", {setter}); }} }}";

public Func<string, string, string, string, string> FluentGenerator { get; set; }

Expand Down