Use standard named for native manipulation functions. NFC #21555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
approved these changes
Mar 19, 2024
sbc100
force-pushed
the
stack_functions
branch
3 times, most recently
from
351ca40 to
fdc7de5
Compare
Collaborator
Author
|
All the apparent regression in wasm code size in this PR are because we don't enable minifiction of import/export names in the metadce tests, so they are sensitive the length of the function names. However, in normal |
kripken
reviewed
Mar 20, 2024
sbc100
force-pushed
the
stack_functions
branch
4 times, most recently
from
c8acb8a to
acb63c8
Compare
We continue to use the JS names when calling from JS code but use prefixed, native symbol names for the native implementation. I'm hoping we can eventually completely remove the `WASM_SYSTEM_EXPORTS` special casing.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 21, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 21, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 23, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 23, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 25, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 25, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
that referenced
this pull request
Mar 25, 2024
Followup to #21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
mathetake
pushed a commit
to wazero/wazero
that referenced
this pull request
Jul 19, 2024
This update the imports/emscripten package implementation so that it can support v3.1.57+ which came with a breaking change: emscripten-core/emscripten#21555 Signed-off-by: Jeroen Bobbeldijk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We continue to use the JS names when calling from JS code but use prefixed, native symbol names for the native implementation.
I'm hoping we can eventually completely remove the
WASM_SYSTEM_EXPORTSspecial casing.