Use _emscripten_ prefix for getTempRet0/setTempRet0 exports. NFC
#21579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
changed the title
_emscripten_ prefix for getTempRet0/setTempRet0. NFC_emscripten_ prefix for getTempRet0/setTempRet0 exports. NFC
sbc100
force-pushed
the
getTempRet0
branch
3 times, most recently
from
ff75099 to
ee7bcc1
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
`wasm-emscripten-finalize` will always performs some amount of type legalization unless WASM_BIGINT is enabled. The logic in `finalize_wasm` was getting this wrong. I'm not sure exactly what the side effects of this are today but I'm working on change to `getTempRet0`/`setTempRet0` handling where this becomes a problem because `js_legalization_pass_flags` was not being passed to `wasm-emscripten-finalize` even though some amount of legalization was happening. This was only effecting the `WASM_BIGINT=0` + `LEGALIZE_JS_FFI=0` case in which partial legalization occurs. See: emscripten-core#21579
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Mar 22, 2024
`wasm-emscripten-finalize` will always performs some amount of type legalization unless WASM_BIGINT is enabled. The logic in `finalize_wasm` was getting this wrong. I'm not sure exactly what the side effects of this are today but I'm working on change to `getTempRet0`/`setTempRet0` handling where this becomes a problem because `js_legalization_pass_flags` was not being passed to `wasm-emscripten-finalize` even though some amount of legalization was happening. This was only effecting the `WASM_BIGINT=0` + `LEGALIZE_JS_FFI=0` case in which partial legalization occurs. See: emscripten-core#21579
sbc100
force-pushed
the
getTempRet0
branch
3 times, most recently
from
36988cf to
3422236
Compare
kripken
approved these changes
Mar 25, 2024
Followup to emscripten-core#21555 In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the `WASM_SYSTEM_EXPORTS` special casing which simplifies the code in bunch of places.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Jan 3, 2025
`wasm-emscripten-finalize` will always performs some amount of type legalization unless WASM_BIGINT is enabled. The logic in `finalize_wasm` was getting this wrong. I'm not sure exactly what the side effects of this are today but I'm working on change to `getTempRet0`/`setTempRet0` handling where this becomes a problem because `js_legalization_pass_flags` was not being passed to `wasm-emscripten-finalize` even though some amount of legalization was happening. This was only effecting the `WASM_BIGINT=0` + `LEGALIZE_JS_FFI=0` case in which partial legalization occurs. See: emscripten-core#21579
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #21555
In addition to helping avoid symbol collisions this has the great side effect that we can now completely remove the
WASM_SYSTEM_EXPORTSspecial casing which simplifies the code in bunch of places.