Skip to content

Fix relational fields without to_fields attribute. #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lovelydinosaur merged 3 commits into from
Nov 16, 2015
Merged

Fix relational fields without to_fields attribute. #3635

lovelydinosaur merged 3 commits into from
Nov 16, 2015

Conversation

@martinhill
Copy link

@martinhill martinhill commented Nov 14, 2015

Fixes issue 3634

xordoquy
xordoquy reviewed Nov 14, 2015
View reviewed changes
rest_framework/utils/model_meta.py Outdated
Copy link
Contributor

@xordoquy xordoquy Nov 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the new line doesn't check whether to_fields is None or not

@martinhill
Copy link
Author

martinhill commented Nov 15, 2015

Sorry for multiple commits, that should be the final one.

@xordoquy xordoquy added this to the 3.3.2 Release milestone Nov 15, 2015
@xordoquy xordoquy changed the title fix for issue #3634 Relation fields no to_fields attribute attribute break serializer Nov 15, 2015
@xordoquy
Copy link
Contributor

xordoquy commented Nov 16, 2015

Wondering whether we need a test here - most likely we do

lovelydinosaur
lovelydinosaur reviewed Nov 16, 2015
View reviewed changes
rest_framework/utils/model_meta.py
Copy link
Contributor

@lovelydinosaur lovelydinosaur Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we us hasattr instead?

Copy link
Contributor

@xordoquy xordoquy Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomchristie no, cf my previous outdated comment

Copy link
Contributor

@lovelydinosaur lovelydinosaur Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack - ignore my comment there. Incorrect.

@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Nov 16, 2015

Wondering whether we need a test here - most likely we do

For simple cases I'm kinda okay with us simply switching out a more brittle style for a safer style. A test case would be appreciated, but would probably accept either way.

@martinhill
Copy link
Author

martinhill commented Nov 16, 2015

Agreed – I could definitely add a test case, but might take a couple days.

lovelydinosaur added a commit that referenced this pull request Nov 16, 2015
@lovelydinosaur
Merge pull request #3635 from martinhill/issue_3634
316c374 
Relation fields no to_fields attribute attribute break serializer
@lovelydinosaur lovelydinosaur merged commit 316c374 into encode:master Nov 16, 2015
@xordoquy xordoquy changed the title Relation fields no to_fields attribute attribute break serializer Fix relational fields without to_fields attribute. Dec 14, 2015
@pyup-bot pyup-bot mentioned this pull request Oct 22, 2016
Merged
@pyup-bot pyup-bot mentioned this pull request Oct 30, 2016
Merged
@pyup-bot pyup-bot mentioned this pull request Feb 26, 2017
Merged
This was referenced Mar 9, 2017
Closed
Closed
Closed
@pyup-bot pyup-bot mentioned this pull request Jun 7, 2017
Closed
@pyup-bot pyup-bot mentioned this pull request Sep 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

3.3.2 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@martinhill @xordoquy @lovelydinosaur