Skip to content

Fix relational fields without to_fields attribute. #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lovelydinosaur merged 3 commits into from
Nov 16, 2015
Merged

Fix relational fields without to_fields attribute. #3635

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e475464
fix for issue #3634
Nov 14, 2015
bac6f1f
check if field.to_fields is None
Nov 14, 2015
ff36cbe
same logic, more pythonic
Nov 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
same logic, more pythonic
  • Loading branch information
Martin Hill committed Nov 15, 2015
commit ff36cbe4baa50302aa566c1d188a5f98393fd895
2 changes: 1 addition & 1 deletion rest_framework/utils/model_meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _get_fields(opts):


def _get_to_field(field):
return field.to_fields[0] if hasattr(field, 'to_fields') and field.to_fields else None
return getattr(field, 'to_fields', None) and field.to_fields[0]
Copy link
Contributor

@lovelydinosaur lovelydinosaur Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we us hasattr instead?

Copy link
Contributor

@xordoquy xordoquy Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomchristie no, cf my previous outdated comment

Copy link
Contributor

@lovelydinosaur lovelydinosaur Nov 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack - ignore my comment there. Incorrect.



def _get_forward_relationships(opts):
Expand Down