Empty cases of .validated_data and .errors as lists not dicts for ListSerializer #4180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovelydinosaur
deleted the
empty-cases-as-lists-not-dicts-for-listserializer
branch
Contributor
|
@tomchristie thanks for picking this up |
Contributor
Author
|
No problem! Trying to get the issue list into shape as part of the funded work right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
.is_validfails for a ListSerializer, the.validated_dataattribute should be[], not{}.When
is_validpasses for a ListSerializer, the.errorsattribute should be[], not{}.Note that users don't typically hit this, as they've already checked
is_valid, so the empty case doesn't get typically get inspected.Closes #3437.
Closes #3434.
Closes #3476.
Thanks to @nip3o, @jpadilla and @xordoquy.