Skip to content

PR template related changes and The Big Warning Cleanup #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bugadani wants to merge 13 commits into from
Closed

PR template related changes and The Big Warning Cleanup #666

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
aca0c1d
Remove todo items checked by CI
bugadani Jul 20, 2023
9bf0748
Ensure warnings are not accepted
bugadani Jul 20, 2023
cddfeff
Resolve xtensa-specific warnings
bugadani Jul 20, 2023
7a73c52
Resolve riscv specific warnings
bugadani Jul 20, 2023
2d72178
Run checks in the specific directories
bugadani Jul 20, 2023
d0d5164
Check smartled crate with the correct targets
bugadani Jul 20, 2023
f8f16c4
Rustdoc improvements
bugadani Jul 20, 2023
37bf335
Format efuse bracketed names as code
bugadani Jul 20, 2023
471f7a7
Fix RMT spelling
bugadani Jul 20, 2023
f6ff5f1
Fix SPI docs
bugadani Jul 20, 2023
ebeddb6
Check interrupt_preemption examples with nightly
bugadani Jul 20, 2023
58933ff
Resolve example warnings
bugadani Jul 20, 2023
1a6e144
Work around warnings in riscv rt
bugadani Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove todo items checked by CI
  • Loading branch information
@bugadani
bugadani committed Jul 20, 2023
commit aca0c1d3afde3cc36467592ac852e3376db073d0
6 changes: 2 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@ Please make sure that your submission includes the following:

### Must

- [ ] The code compiles without `errors` or `warnings`.
- [ ] All examples compile without warnings.
- [ ] All examples work.
- [ ] `cargo fmt` was run.
- [ ] Your changes were added to the `CHANGELOG.md` in the proper section.
- [ ] You updated existing examples or added examples (if applicable).
- [ ] Added examples are checked in CI
- [ ] Added examples are checked in CI.

### Nice to have

Expand Down