Fix psram check in esp-hal-common build.rs #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessebraham
approved these changes
Aug 12, 2023
Member
jessebraham
left a comment
jessebraham
left a comment
There was a problem hiding this comment.
Good catch, thanks for fixing that!
I can probably do a patch release of esp-hal-common next week some time, just would like a couple extra days to look for additional issues.
Contributor
Author
|
Sounds great! Thanks for the quick approval, I just added a line to the changelog as was requested by the CI. |
bugadani
pushed a commit
to bugadani/esp-hal
that referenced
this pull request
Aug 20, 2023
* Fix psram check in esp-hal-common build.rs * Update changelog.
playfulFence
pushed a commit
to playfulFence/esp-hal
that referenced
this pull request
Sep 26, 2023
* Fix psram check in esp-hal-common build.rs * Update changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
esp-hal-commonbuild script,psramis a peripheral "defined by the developers". A few weeks ago these were moved fromdevice.peripheralstodevice.symbols. When looking up whetherpsramis available, now needs to be looked up insymbols.Closes #717