Skip to content

Fix psram check in esp-hal-common build.rs #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessebraham merged 2 commits into from
Aug 13, 2023
Merged

Fix psram check in esp-hal-common build.rs #718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
583fce2
Fix psram check in esp-hal-common build.rs
jsosulski Aug 12, 2023
2879cf6
Update changelog.
jsosulski Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- Fix `psram` availability lookup in `esp-hal-common` build script (#718)

### Removed

## [0.11.0] - 2023-08-10
Expand Down
2 changes: 1 addition & 1 deletion esp-hal-common/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ fn main() {
}

// Check PSRAM features are only given if the target supports PSRAM
if !&device.peripherals.contains(&String::from("psram"))
if !&device.symbols.contains(&String::from("psram"))
&& (cfg!(feature = "psram_2m") || cfg!(feature = "psram_4m") || cfg!(feature = "psram_8m"))
{
panic!("The target does not support PSRAM");
Expand Down