-
Notifications
You must be signed in to change notification settings - Fork 367
Make sure examples can actually build with defmt enabled, build some examples in CI #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Turns out, many of the current examples (that are checked by CI) don't actually link. Part of the problem is defmt, which is fixed by this PR (though I'm still very much confused why e-h-common can build at all, even though |
c8e8199 to
7ed4e34
Compare
|
looks good to me but I'd like to leave the final word on this to @jessebraham since he did most of the work on CI |
jessebraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in getting to this, thanks for making that change. LGTM!
|
Hold on please, things don't build locally. |
|
At this point I'm getting pretty concerned that we've added this |
|
This PR wasn't trying to get CI to verify the feature, but I can add a |
|
The title of the PR is Make sure examples can actually build with defmt enabled, CI is green, and you're saying it's not building. Maybe I'm misunderstanding but this doesn't seem right. |
|
Yeah, this is a fix to build the examples locally. I didn't want to increase CI times by turning some cargo checks into cargo builds. |
|
@jessebraham if you're fine with |
…examples in CI (esp-rs#810) * Make sure examples can build with defmt * Remove duplicate example checks * Fix examples * Add changelog entry * Actually build some examples with defmt feature enabled * Add the defmt linker script in each package's build script
This PR:
defmtfeature not only passescargo checkbut actually builds+nightlytoolchain spec for consistencyesp-println/logby defaultlogdisabled