Add SYSTIMER ETM #828
Merged
Add SYSTIMER ETM #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjoernQ
force-pushed
the
feature/systimer-etm
branch
from
040acd8 to
fd46802
Compare
bugadani
reviewed
Sep 28, 2023
|
|
||
| #[entry] | ||
| fn main() -> ! { | ||
| esp_println::logger::init_logger_from_env(); |
Contributor
There was a problem hiding this comment.
Please put these behind a #[cfg(feature = "log")]. I just cleaned up like 26 of these in #810 and that isn't a fun activity
Contributor
There was a problem hiding this comment.
Also please add the examples to CI
Contributor
Author
There was a problem hiding this comment.
ah I keep forgetting about the log vs defmt thing 👍 most probably will just remove it
Contributor
There was a problem hiding this comment.
Normally this should fail in CI but these examples aren't checked (yet) ;)
Contributor
Author
There was a problem hiding this comment.
we do cargo build --examples? there are no features needed so it should build it
Contributor
There was a problem hiding this comment.
True enough. esp-println's log is currently enabled by default right now which makes this pass...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ETM functionality to SYSTIMER