Refactor the spi and spi_slave modules into a common spi module
#843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I also tested QSPI after this change - everything still works (was expected but better safe than sorry) |
MabezDev
pushed a commit
to MabezDev/esp-hal
that referenced
this pull request
Oct 20, 2023
…esp-rs#843) * Refactor the `spi` and `spi_slave` modules into a single `spi` module * Update import paths in examples as needed * Extract some common types from `spi::master` into the root `spi` module * Fix imports in examples (again) * Documentation fixes/improvements * Remove unnecessary re-exports * Update `CHANGELOG.md`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've extracted any types which are used by both operational modes into the root
spimodule, while any mode-specific types and implementations are in their respective modules. Pretty self-explanatory, I think, but let me know if you have any questions/concerns.