Fix Translation Acknowledgement bugs #4678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uages for a contributor on TranslationLeaderboard
corwintines
requested review from
minimalsm,
pettinarip,
samajammin and
wackerow
as code owners
minimalsm
approved these changes
Dec 7, 2021
Member
|
Looks good! Only thought is for situations where someone works on a bunch of languages: Should we just display the 1st 3 languages, or something along those lines? |
wackerow
approved these changes
Dec 10, 2021
Member
wackerow
left a comment
wackerow
left a comment
There was a problem hiding this comment.
Lookin good =)
@samajammin Agree, would probably be reasonable to draw the line somewhere here. To make this more friendly on mobile, think 3 is a reasonable place to start. @lukassim Curious your take on this.
This is limiting to three and I think looks a lot cleaner. Will patch with this and pull in, can adjust easily if needed.
Gatsby Cloud Build Reportethereum-org-website-dev2 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 5m PerformanceLighthouse report
|
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Preview: https://deploy-preview-4678--ethereumorg.netlify.app/en/contributing/translation-program/contributors/