Skip to content

Fix Translation Acknowledgement bugs #4678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wackerow merged 3 commits into from
Dec 10, 2021
Merged

Fix Translation Acknowledgement bugs #4678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
283925d
fix: contributors only display on 1 row for mobile, and show all lang…
corwintines Dec 7, 2021
210cef7
limit to 3 languages/user for leaderboard
wackerow Dec 10, 2021
bf375a4
Merge branch 'dev' into translation-acknowledgement-bugs
wackerow Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions src/components/TranslationLeaderboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ const Avatar = styled.img`
}
`

const NameContainer = styled.div`
@media (max-width: ${(props) => props.theme.breakpoints.s}) {
max-width: 100px;
}
`

const Width40 = styled.div`
width: 40px;
`
Expand Down Expand Up @@ -197,10 +203,15 @@ const TranslationLeaderboard = () => {
)}
<TextContainer>
<Avatar src={user.avatarUrl} />
<div>
<NameContainer>
{user.username}
<Language>{languages[0]?.name || ""}</Language>
</div>
<Language>
{languages
.slice(0, 3)
.map((language) => language.name)
.join(", ")}
</Language>
</NameContainer>
</TextContainer>
</Flex>
<WordsContainer>
Expand Down
4 changes: 4 additions & 0 deletions src/pages/contributing/translation-program/contributors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ const HorizontalUl = styled.ul`
@media (max-width: ${(props) => props.theme.breakpoints.m}) {
grid-template-columns: 1fr 1fr;
}

@media (max-width: ${(props) => props.theme.breakpoints.s}) {
grid-template-columns: 1fr;
}
`

const Contributors = ({ location }) => {
Expand Down