Malay: New language, homepage #4747
Conversation
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev2 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 7m PerformanceLighthouse report
|
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
|
@wackerow where are we at with this 😀? |
wackerow
requested review from
corwintines,
minimalsm,
pettinarip and
samajammin
as code owners
gatsby-node.js
Outdated
| const langHasOutdatedMarkdown = fs.existsSync(markdownPath) | ||
| if (!langHasOutdatedMarkdown) { | ||
| // Check if json strings exists for language, if not mark `isContentEnglish` as true | ||
| const jsonPath = `${__dirname}/src/intl/${lang}/page-${page}.json` |
There was a problem hiding this comment.
Could we just use the existing helper function checkIsPageOutdated for this? cc @corwintines
There was a problem hiding this comment.
I'm also not sure if this check is needed at all, given that we perform checkIsPageOutdated within onCreatePage, although I'm not certain that is triggered when we call createPage below this.
There was a problem hiding this comment.
I don't believe it does trigger it from that method itself. exports.onCreatePage calls createPage() itself and would appear to cause a recursive loop if that method also triggered the lifecycle hook. Placing this here fixes the "pages-conditional" that were having the issues.
I updated to use checkIsPageOutdated, and merged in dev / cleared conflicts.
corwintines
left a comment
corwintines
left a comment
There was a problem hiding this comment.
LGTM! Thanks for catching the page-conditional thing @wackerow!
Description
Adds Malay (ms) to list of languages
Import homepage strings from Crowdin
Utilizes updated legacy homepage logic from Arabic: Homepage updated #4723
Check banner logic