Arabic: Homepage updated #4723
Merged
Arabic: Homepage updated #4723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary, will be phased out after new homepage translated for all languages (prioritized)
wackerow
requested review from
corwintines,
minimalsm,
pettinarip and
samajammin
as code owners
github-actions
bot
added
content 🖋️
Gatsby Cloud Build Reportethereum-org-website-dev2 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
This was referenced Dec 11, 2021
for `ar` and `fa` language locales
Contributor
|
LGTM. Could definitely do a clean-up to support rtl better. But seems like it could get messy real quick... (see nav screenshot) Nav
Mobile navThis should be flipped
### Footer Should be rtl
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description