Skip to content

Conversation

@wackerow
Copy link
Member

Description

  • Updates the German (de) homepage to latest translations from Crowdin.
  • Updates "Use Ethereum" content bucket*
  • Utilizes updated legacy homepage logic from Arabic: Homepage updated #4723, and updates de to use newer page

* This includes /eth2 markdown files which required manual touch-up from raw Crowdin import. See notes here:
https://www.notion.so/efdn/12-11-2021-Crowdin-Import-Notes-e7fccce737164ac6bb8ea7659fb95ebf

Temporary, will be phased out after new homepage translated for all languages (prioritized)
remove `"useLegacyHomepage": true` from `de`
@github-actions github-actions bot added content 🖋️ This involves copy additions or edits review needed 👀 translation 🌍 This is related to our Translation Program labels Dec 11, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 11, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 6m

Performance

Lighthouse report

Metric Score
Performance 🔶 21
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 11, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev2

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 6m

Performance

Lighthouse report

Metric Score
Performance 🔶 22
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of date error

A couple of problems have been introduced due to a lack of sync between our English JSON files in dev and the JSON files we've pulled from CrowdIn. This is causing several pages to mistakenly label pages that are out-of-date. Documenting here but worth noting this is probably happening on all of the updates we uploaded yesterday.

Current pages that are showing as out-of-date that shouldn't be are:

  1. /wallets/find-wallet/
    -- Caused by having page-find-wallet-yet reintroduced in page-wallets-find-wallet.json. I've removed it and merged the text from it to page-find-wallet-not-all-features

  2. /eth2/
    -- Caused by re-adding eth2-client-trinity-logo-alt back into page-eth2-index.json. I have removed it (Trinity client is deprecated and we don't list it anymore here)

  3. /eth2/vision/
    -- Caused by re-adding page-eth2-vision-The. I've deleted this. We don't need to add anything as this is not used (confirmed by searching an old branch from August that this hasn't been used in /eth2/vision.js for a while.

  4. /eth2/merge/
    -- I think this might be caused by deleting the comment that has a heading in it? (We now check the number of headings in markdown files I believe?) I've re-introduced this temporarily to test this assumption.

Screenshot 2021-12-13 at 10 45 57

  1. /eth2/bug-bounty/
    -- Caused by reintroducing page-eth2-bug-bounty-quality-fix-desc in page-eth2-get-involved-bug-bounty.json. I've removed this and merged the content into page-eth2-bug-bounty-quality-fix
    -- Note: this makes the third list item here lose its description

Screenshot 2021-12-13 at 10 29 11


Programmatic text in strings

Not a new issue but noticed more than a few occurrences of translators trying to add programmatic things in text (i.e. \nwerden sämtliche Prämien für auf or hinzugefügt wird, \"zusammengeführt\".

Didn't want to spend too long on this but we should probably do a sweep of the codebase for this after we merge all the new language content.


Merge / Sharding dates

Merge/sharding dates have been knocked back to the previous version for this. Again, we should do a sweep after merging.

@minimalsm
Copy link
Contributor

minimalsm commented Dec 13, 2021

All issues fixed except find-wallets is still showing as out of date. Maybe we added new wallets?

@minimalsm minimalsm merged commit 5cc5ece into dev Dec 15, 2021
@minimalsm minimalsm deleted the de-crowdin branch December 15, 2021 16:20
@wackerow wackerow mentioned this pull request Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content 🖋️ This involves copy additions or edits translation 🌍 This is related to our Translation Program

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants