-
Notifications
You must be signed in to change notification settings - Fork 5.4k
German: Homepage and Use Ethereum updated #4748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Temporary, will be phased out after new homepage translated for all languages (prioritized)
remove `"useLegacyHomepage": true` from `de`
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
Gatsby Cloud Build Reportethereum-org-website-dev2 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 6m PerformanceLighthouse report
|
minimalsm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of date error
A couple of problems have been introduced due to a lack of sync between our English JSON files in dev and the JSON files we've pulled from CrowdIn. This is causing several pages to mistakenly label pages that are out-of-date. Documenting here but worth noting this is probably happening on all of the updates we uploaded yesterday.
Current pages that are showing as out-of-date that shouldn't be are:
-
/wallets/find-wallet/
-- Caused by havingpage-find-wallet-yetreintroduced inpage-wallets-find-wallet.json. I've removed it and merged the text from it topage-find-wallet-not-all-features -
/eth2/
-- Caused by re-addingeth2-client-trinity-logo-altback intopage-eth2-index.json. I have removed it (Trinity client is deprecated and we don't list it anymore here) -
/eth2/vision/
-- Caused by re-addingpage-eth2-vision-The. I've deleted this. We don't need to add anything as this is not used (confirmed by searching an old branch from August that this hasn't been used in/eth2/vision.jsfor a while. -
/eth2/merge/
-- I think this might be caused by deleting the comment that has a heading in it? (We now check the number of headings in markdown files I believe?) I've re-introduced this temporarily to test this assumption.
- /eth2/bug-bounty/
-- Caused by reintroducingpage-eth2-bug-bounty-quality-fix-descinpage-eth2-get-involved-bug-bounty.json. I've removed this and merged the content intopage-eth2-bug-bounty-quality-fix
-- Note: this makes the third list item here lose its description
Programmatic text in strings
Not a new issue but noticed more than a few occurrences of translators trying to add programmatic things in text (i.e. \nwerden sämtliche Prämien für auf or hinzugefügt wird, \"zusammengeführt\".
Didn't want to spend too long on this but we should probably do a sweep of the codebase for this after we merge all the new language content.
Merge / Sharding dates
Merge/sharding dates have been knocked back to the previous version for this. Again, we should do a sweep after merging.
|
All issues fixed except find-wallets is still showing as out of date. Maybe we added new wallets? |


Description
deto use newer page* This includes
/eth2markdown files which required manual touch-up from raw Crowdin import. See notes here:https://www.notion.so/efdn/12-11-2021-Crowdin-Import-Notes-e7fccce737164ac6bb8ea7659fb95ebf