Skip to content

Conversation

@samajammin
Copy link
Member

Description

Test to see if Gatsby Cloud changes the relativePath and/or editPath

Related Issue

#4710

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 13, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 4m

Performance

Lighthouse report

Metric Score
Performance 🔶 22
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 13, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev2

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 4m

Performance

Lighthouse report

Metric Score
Performance 🔶 20
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

@wackerow
Copy link
Member

@samajammin I'm seeing src/app/www getting added to the start of relativePath.

# developers/docs/evm/opcodes

## Locally with `yarn start`, which is properly loading contributors
editPath: "https://github.com/ethereum/ethereum-org-website/tree/dev/src/content/developers/docs/evm/opcodes/index.md"
relativePath: "src/content/developers/docs/evm/opcodes/index.md"

## Gatsby logs from this PR
editPath: 'https://github.com/ethereum/ethereum-org-website/tree/dev/src/app/www/src/content/developers/docs/evm/opcodes/index.md'
relativePath: 'src/app/www/src/content/developers/docs/evm/opcodes/index.md',

@wackerow
Copy link
Member

@samajammin

const relativePathStart = absolutePath.indexOf("src/")

Maybe we should change this to .lastIndexOf('src/') (perhaps only in production), since these paths seem to have a different src/ folder as the root.

@minimalsm
Copy link
Contributor

Issue solved in #4763. Closing :-)

@minimalsm minimalsm closed this Dec 14, 2021
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label Dec 14, 2021
@minimalsm minimalsm deleted the gh-api-gc branch June 21, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned This has been abandoned or will not be implemented

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants