Skip to content

Conversation

@wackerow
Copy link
Member

@wackerow wackerow commented Dec 14, 2021

Description

Relative path is being passed with src/app/www at the beginning, when it previously did not prior to Gatsby Cloud migration.

  • Changes gatsby-node logic to find last instance of src/ as starting point for relative path.
  • Corrects relativePath and editPath for GitHub queries

Deploy preview: https://ethereumorgwebsitedev01-relativepath.gtsb.io/en/developers/docs/
Screenshot:
image

Related Issue

[Fixes #4710]
More comments on the issue here #4762

Corrects `relativePath` and `editPath` for GitHub queries
@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 14, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 21
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

@gatsby-cloud
Copy link

gatsby-cloud bot commented Dec 14, 2021

Gatsby Cloud Build Report

ethereum-org-website-dev2

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 8m

Performance

Lighthouse report

Metric Score
Performance 🔶 21
Accessibility 💚 97
Best Practices 💚 93
SEO 🔶 79

🔗 View full report

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev docs contributors not fetching

3 participants