fix(tests): Incorrect expected exception on test_tx_intrinsic_gas.py
#2096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess_list/test_tx_intrinsic_gas.py`
marioevz
added
type:bug
Member
Author
|
Cc @kclowes, I had time to check this today and put up a PR, just to not duplicate efforts. |
Collaborator
|
Ah nice. I was thinking something along these lines would be ideal since these are both "gas too low" paths, just one more specific than another. I think this approach makes sense 👌🏼 |
|
|
|
Koło |
|
Lolo |
LouisTsai-Csie
pushed a commit
to LouisTsai-Csie/execution-spec-tests
that referenced
this pull request
Sep 5, 2025
ethereum#2096) * fix(tests): Incorrect expected exception on `tests/berlin/eip2930_access_list/test_tx_intrinsic_gas.py` * fix: typing
5 tasks
kclowes
pushed a commit
to kclowes/execution-spec-tests
that referenced
this pull request
Oct 20, 2025
ethereum#2096) * fix(tests): Incorrect expected exception on `tests/berlin/eip2930_access_list/test_tx_intrinsic_gas.py` * fix: typing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fixes an exception expectation on
test_tx_intrinsic_gas.py.Depending on the implementation, the client could hit
TransactionException.INTRINSIC_GAS_BELOW_FLOOR_GAS_COSTorTransactionException.INTRINSIC_GAS_TOO_LOWbecause both values, given the conditions, were equal.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlinttype(scope):.All: Considered adding an entry to CHANGELOG.md.