Skip to content

fix(tests): Incorrect expected exception on test_tx_intrinsic_gas.py #2096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marioevz merged 2 commits into from
Sep 3, 2025
Merged

fix(tests): Incorrect expected exception on test_tx_intrinsic_gas.py #2096

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
736bd5d
fix(tests): Incorrect expected exception on `tests/berlin/eip2930_acc…
marioevz Sep 2, 2025
b023588
fix: typing
marioevz Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion tests/berlin/eip2930_access_list/test_tx_intrinsic_gas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,29 @@ def test_tx_intrinsic_gas(
intrinsic_gas_cost_calculator = fork.transaction_intrinsic_cost_calculator()
intrinsic_gas_cost = intrinsic_gas_cost_calculator(calldata=data, access_list=access_list)

exception: List[TransactionException] | TransactionException | None = None
if below_intrinsic:
data_floor_gas_cost_calculator = fork.transaction_data_floor_cost_calculator()
data_floor_gas_cost = data_floor_gas_cost_calculator(data=data)
if data_floor_gas_cost > intrinsic_gas_cost:
exception = TransactionException.INTRINSIC_GAS_BELOW_FLOOR_GAS_COST
elif data_floor_gas_cost == intrinsic_gas_cost:
# Depending on the implementation, client might raise either exception.
exception = [
TransactionException.INTRINSIC_GAS_TOO_LOW,
TransactionException.INTRINSIC_GAS_BELOW_FLOOR_GAS_COST,
]
else:
exception = TransactionException.INTRINSIC_GAS_TOO_LOW

tx = Transaction(
ty=tx_type,
sender=pre.fund_eoa(),
to=pre.deploy_contract(code=Op.SSTORE(0, Op.ADD(1, 1))),
data=data,
access_list=access_list,
gas_limit=intrinsic_gas_cost + (-1 if below_intrinsic else 0),
error=TransactionException.INTRINSIC_GAS_TOO_LOW if below_intrinsic else None,
error=exception,
protected=True,
)

Expand Down
Loading