Skip to content

Error refactoring #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
st31ny wants to merge 4 commits into from
Closed

Error refactoring #93

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8572f14
Add ApiError
st31ny Oct 27, 2019
cf7f312
Use custom MethodNotFoundError instead of KeyError
st31ny Oct 27, 2019
0fc363d
Add InvalidArgumentsError
st31ny Oct 27, 2019
8dab280
Add logging if method fails
st31ny Oct 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add logging if method fails
  • Loading branch information
@st31ny
st31ny committed Oct 27, 2019
commit 8dab28021585e72d3a2634f10c0423ad20d2ec68
1 change: 1 addition & 0 deletions jsonrpcserver/dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ def handle_exceptions(request: Request, debug: bool) -> Generator:
debug=True,
)
except Exception as exc: # Other error inside method - server error
request_logger.exception("Error in method {!r} for request with id {}".format(request.method, request.id))
handler.response = ExceptionResponse(exc, id=request.id, debug=debug)
finally:
if request.is_notification:
Expand Down