Error refactoring #93
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Allows methods to signal user-defined error condition.
* Avoid responding with a method not found error if a KeyError is raised in a method implementation.
* Avoid confusion with random type errors in methods.
Collaborator
Author
|
Sure, no worries. So, I guess the |
Member
|
It’s not breaking so it can go into a minor release, as long as we leave AssertionError for now. |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some refactoring of the error handling mechanisms and tried to address the issues #71 and #72.
I introduced a new
ApiErrorfor custom errors with message and optional code and data. The usage ofKeyErrorfor method-not-found andTypeErrorfor invalid params have been replaced by custom exceptions, so that there is no confusion between these client errors and other internal server errors.A point for discussion is whether to keep
AssertionErrorscausing anInvalidParamsResponse. While assertions can be used for argument validation they might also simply check internal server invariants which should cause a generic server error.Note: I only tested against py37. Can sb run the tests on 3.6 and 3.8, please?