Use custom exception to signal a client error #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2019
Closed
Member
|
Thanks for submitting, it looks good, will take a closer look asap. |
Member
|
Need to update the documentation (the doc directory) |
Collaborator
Author
|
Ok, I'll have a look at that, too. |
Member
|
Thanks @steinymity Haven’t forgotten this, I have some time off work after today so I can give it a proper review. |
Collaborator
Author
|
Are there any outstanding comments as suggested in #95? Github doesn't show me any in the code, though… |
Member
|
No they’re in this one, you should see them in pending status above? |
Collaborator
Author
|
No, sorry, I can't see them. Even when looking at the commits or at the diff I cannot see any comment. Maybe I'm missing the rights to see them? |
bcb
requested changes
Nov 11, 2019
Member
|
Sorry I had to submit the review! |
Collaborator
Author
|
No worries , I just commented/resolved the issues. |
bcb
approved these changes
Nov 12, 2019
bcb
requested changes
Nov 12, 2019
* Allows methods to signal user-defined error condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #71 and introduces a new
ApiErrorexception type.