Skip to content

Dispose error overlay when linting errors have been corrected #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 11, 2016
Merged

Dispose error overlay when linting errors have been corrected #856

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c18164
Dispose error overlay when linting errors have been corrected
jarlef Oct 5, 2016
15672ac
Fixed spelling error
jarlef Oct 10, 2016
34c739b
Minor style tweaks
gaearon Oct 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/react-dev-utils/webpackHotDevClient.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,18 @@ function showErrorOverlay(message) {
});
}

function destoryOverlay() {
Copy link
Contributor

@wdhorton wdhorton Oct 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor thing, but you probably meant "destroy" rather than "destory", right?

Copy link
Contributor Author

@jarlef jarlef Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. pardon my spelling error ;-)

if(!overlayDiv) {
//linting from previous linting was successful
return;
}

document.body.removeChild(overlayIframe);
overlayDiv = null;
overlayIframe = null;
lastOnOverlayDivReady = null;
}

// Connect to WebpackDevServer via a socket.
var connection = new SockJS(url.format({
protocol: window.location.protocol,
Expand Down Expand Up @@ -156,6 +168,7 @@ function clearOutdatedErrors() {
// Successful compilation.
function handleSuccess() {
clearOutdatedErrors();
destoryOverlay();

var isHotUpdate = !isFirstCompilation;
isFirstCompilation = false;
Expand All @@ -170,6 +183,7 @@ function handleSuccess() {
// Compilation with warnings (e.g. ESLint).
function handleWarnings(warnings) {
clearOutdatedErrors();
destoryOverlay();

var isHotUpdate = !isFirstCompilation;
isFirstCompilation = false;
Expand Down