[JS Polyfills] Also call the original console methods if they exist
#1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ex. When `console.log` or similar is called, this will call the original method, which can be quite useful. For example, under iOS, this will log to the Safari console debugger, which has an expandable UI for inspecting objects, etc., and is also just useful if you are using that as a REPL. I don't believe this incurs a meaningful performance penalty unless the console is open, but it would be easy to stick behind a flag if that is a problem.
facebook-github-bot
added
the
CLA Signed
Collaborator
|
@vjeux - this looks good to me, do you see any issues with pulling this in? |
brentvatne
changed the title
console methods if they existconsole methods if they exist
Adds in install instructions for `react-timer-mixin` to the `TimerMixin` docs.
…g code to add more links progressively
Ex. When `console.log` or similar is called, this will call the original method, which can be quite useful. For example, under iOS, this will log to the Safari console debugger, which has an expandable UI for inspecting objects, etc., and is also just useful if you are using that as a REPL. I don't believe this incurs a meaningful performance penalty unless the console is open, but it would be easy to stick behind a flag if that is a problem.
It's now moved to ./packager/react-packager/src/DependencyResolver/polyfills/console.js
Contributor
|
Sorry for the super long review time :x Can you get rid of all the unrelated changes and rebase? Thanks! |
Contributor
Contributor
|
merged (w original author attribution!) |
ryanlntn
pushed a commit
to ryanlntn/react-native
that referenced
this pull request
Aug 9, 2022
* update package.json files and yarn lock * yarn prettier --fix * Fix remaining yarn lint issues * Fix integration CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex. When
console.logor similar is called, this will callthe original method, which can be quite useful.
For example, under iOS, this will log to the Safari console debugger,
which has an expandable UI for inspecting objects, etc., and is also
just useful if you are using that as a REPL.
I don't believe this incurs a meaningful performance penalty unless
the console is open, but it would be easy to stick behind a flag
if that is a problem.