Also call the original console methods if they exist
#742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ex. When `console.log` or similar is called, this will call the original method, which can be quite useful. For example, under iOS, this will log to the Safari console debugger, which has an expandable UI for inspecting objects, etc., and is also just useful if you are using that as a REPL. I don't believe this incurs a meaningful performance penalty unless the console is open, but it would be easy to stick behind a flag if that is a problem. A slightly different version of this patch was submitted a while ago and merged but something got screwed up with the merge and this change was not actually pulled in. (See the weird unrelated commits and changes attached to the PR #205)
facebook-github-bot
added
the
CLA Signed
…sole methods - Fixed a small bug related to variable capture - Made code more concise and hopefully clearer and more readbale - Added a comment about what "native" refers to
ide
pushed a commit
to ide/react-native
that referenced
this pull request
Apr 8, 2015
…inal console methods - Fixed a small bug related to variable capture - Made code more concise and hopefully clearer and more readbale - Added a comment about what "native" refers to
ide
pushed a commit
to ide/react-native
that referenced
this pull request
Apr 10, 2015
…inal console methods - Fixed a small bug related to variable capture - Made code more concise and hopefully clearer and more readbale - Added a comment about what "native" refers to
ide
pushed a commit
to ide/react-native
that referenced
this pull request
Apr 10, 2015
…inal console methods - Fixed a small bug related to variable capture - Made code more concise and hopefully clearer and more readbale - Added a comment about what "native" refers to
ide
pushed a commit
to ide/react-native
that referenced
this pull request
Apr 12, 2015
…inal console methods - Fixed a small bug related to variable capture - Made code more concise and hopefully clearer and more readbale - Added a comment about what "native" refers to
ide
pushed a commit
to ide/react-native
that referenced
this pull request
Apr 13, 2015
…inal console methods - Fixed a small bug related to variable capture - Made code more concise and hopefully clearer and more readbale - Added a comment about what "native" refers to
Collaborator
|
Looks like #1333 is a dupe, closing 😄 |
ayushjainrksh
referenced
this pull request
in MLH-Fellowship/react-native
Jul 2, 2020
From react-native version 0.57.3 default simulator is no longer iPhone 6. More info - facebook@1d1a41e
acoates-ms
pushed a commit
to acoates-ms/react-native
that referenced
this pull request
Aug 3, 2021
* Add high contrast API to AccessibilityInfo * Make RCTAccessibilityManager require main queue setup * Remove unnecessary removeObserver: call * Add comment for macOS "high contrast" = "increase contrast"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ex. When
console.logor similar is called, this will callthe original method, which can be quite useful.
For example, under iOS, this will log to the Safari console debugger,
which has an expandable UI for inspecting objects, etc., and is also
just useful if you are using that as a REPL.
I don't believe this incurs a meaningful performance penalty unless
the console is open, but it would be easy to stick behind a flag
if that is a problem.
A slightly different version of this patch was submitted a while ago
and merged but something got screwed up with the merge and this change
was not actually pulled in. (See the weird unrelated commits and changes
attached to the PR #205)