Skip to content

Also call the original console methods if they exist #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ccheever wants to merge 2 commits into from
Closed

Also call the original console methods if they exist #742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fb9735
Also call the original `console` methods if they exist
ccheever Apr 8, 2015
d50c2c1
Fixing a small bug and simplifying code in #742, calling original con…
ccheever Apr 8, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions packager/react-packager/src/DependencyResolver/haste/polyfills/console.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,11 @@
error: 4
};


function setupConsole(global) {

var originalConsole = global.console;

if (!global.nativeLoggingHook) {
return;
}
Expand Down Expand Up @@ -135,6 +138,18 @@
table: consoleTablePolyfill
};

// If available, also call the original `console` method since that is sometimes useful
// Ex. On OS X, this will let you see rich output to the Safari REPL console
if (originalConsole) {
Object.keys(global.console).forEach((methodName) => {
var nativeMethod = global.console[methodName];
global.console[methodName] = function () {
originalConsole[methodName].apply(originalConsole, arguments);
nativeMethod.apply(global.console, arguments);
};
});
}

}

if (typeof module !== 'undefined') {
Expand Down