Skip to content

Decouple update queue from Fiber type #12600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acdlite merged 10 commits into from
Apr 23, 2018
Merged

Decouple update queue from Fiber type #12600

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2bc15bf
Decouple update queue from Fiber type
acdlite Apr 10, 2018
de45514
Remove first class UpdateQueue types and use closures instead
acdlite Apr 20, 2018
23e859c
Store captured errors on a separate part of the update queue
acdlite Apr 20, 2018
65f5f30
Revert back to storing hasForceUpdate on the update queue
acdlite Apr 20, 2018
712816d
Rename UpdateQueue effect type back to Callback
acdlite Apr 20, 2018
febf9fc
Call getDerivedStateFromProps every render, even if props did not change
acdlite Apr 20, 2018
3c0c540
Store captured effects on separate list from "own" effects (callbacks)
acdlite Apr 20, 2018
5be461c
Optimize for class components
acdlite Apr 21, 2018
891e311
Only double-invoke render phase lifecycles functions in DEV
acdlite Apr 23, 2018
e4ce363
Use global state to track currently processing queue in DEV
acdlite Apr 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove first class UpdateQueue types and use closures instead 
I tried to avoid this at first, since we avoid it everywhere else in the Fiber
codebase, but since updates are not in a hot path, the trade off with file size
seems worth it.
  • Loading branch information
@acdlite
acdlite committed Apr 21, 2018
commit de45514cd6831c91f790182af862311db2249bb4
14 changes: 3 additions & 11 deletions packages/react-noop-renderer/src/ReactNoop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,23 +526,15 @@ const ReactNoop = {

function logUpdateQueue(updateQueue: UpdateQueue<mixed>, depth) {
log(' '.repeat(depth + 1) + 'QUEUED UPDATES');
const firstUpdate = updateQueue.first;
const firstUpdate = updateQueue.firstUpdate;
if (!firstUpdate) {
return;
}

log(
' '.repeat(depth + 1) + '~',
firstUpdate && firstUpdate.partialState,
firstUpdate.callback ? 'with callback' : '',
'[' + firstUpdate.expirationTime + ']',
);
let next;
while ((next = firstUpdate.next)) {
log(' '.repeat(depth + 1) + '~', '[' + firstUpdate.expirationTime + ']');
while (firstUpdate.next) {
log(
' '.repeat(depth + 1) + '~',
next.partialState,
next.callback ? 'with callback' : '',
'[' + firstUpdate.expirationTime + ']',
);
}
Expand Down
26 changes: 11 additions & 15 deletions packages/react-reconciler/src/ReactFiberBeginWork.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,15 @@ import warning from 'fbjs/lib/warning';
import ReactDebugCurrentFiber from './ReactDebugCurrentFiber';
import {cancelWorkTimer} from './ReactDebugFiberPerf';

import ReactFiberClassComponent from './ReactFiberClassComponent';
import ReactFiberClassComponent, {
createGetDerivedStateFromPropsUpdate,
} from './ReactFiberClassComponent';
import {
mountChildFibers,
reconcileChildFibers,
cloneChildFibers,
} from './ReactChildFiber';
import {
createDeriveStateFromPropsUpdate,
enqueueRenderPhaseUpdate,
processClassUpdateQueue,
processRootUpdateQueue,
} from './ReactUpdateQueue';
import {enqueueRenderPhaseUpdate, processUpdateQueue} from './ReactUpdateQueue';
import {NoWork, Never} from './ReactFiberExpirationTime';
import {AsyncMode, StrictMode} from './ReactTypeOfMode';
import MAX_SIGNED_31_BIT_INT from './maxSigned31BitInt';
Expand Down Expand Up @@ -415,7 +412,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
let updateQueue = workInProgress.updateQueue;
if (updateQueue !== null) {
const prevChildren = workInProgress.memoizedState;
processRootUpdateQueue(workInProgress, updateQueue, renderExpirationTime);
processUpdateQueue(workInProgress, updateQueue, renderExpirationTime);
const nextChildren = workInProgress.memoizedState;

if (nextChildren === prevChildren) {
Expand Down Expand Up @@ -595,15 +592,14 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(

const getDerivedStateFromProps = Component.getDerivedStateFromProps;
if (typeof getDerivedStateFromProps === 'function') {
const update = createDeriveStateFromPropsUpdate(renderExpirationTime);
const update = createGetDerivedStateFromPropsUpdate(
getDerivedStateFromProps,
renderExpirationTime,
);
enqueueRenderPhaseUpdate(workInProgress, update, renderExpirationTime);
const updateQueue = workInProgress.updateQueue;
if (updateQueue !== null) {
processClassUpdateQueue(
workInProgress,
updateQueue,
renderExpirationTime,
);
processUpdateQueue(workInProgress, updateQueue, renderExpirationTime);
}
}

Expand Down Expand Up @@ -1080,7 +1076,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
function memoizeState(workInProgress: Fiber, nextState: any) {
workInProgress.memoizedState = nextState;
// Don't reset the updateQueue, in case there are pending updates. Resetting
// is handled by processClassUpdateQueue.
// is handled by processUpdateQueue.
}

function beginWork(
Expand Down
Loading