-
Notifications
You must be signed in to change notification settings - Fork 50.2k
Deprecate context object as a consumer and add a warning message #13829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
trueadm
merged 14 commits into
facebook:master
from
trueadm:deprecate-context-object-as-consumer
Oct 12, 2018
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c902bb5
Deprecate context object as a cosumer and add a warning message
trueadm bd3495c
change to Object.defineProperties
trueadm 6d7d7c0
updated comments
trueadm 773d69d
fix typo
trueadm 22f4359
address feedback
trueadm e39a444
fix flow
trueadm 40fcddb
prettier
trueadm 4b0c8a7
Warn against Context.Consumer.Consumer
trueadm f174b6e
more changes based on feedback
trueadm 59917cd
move line
trueadm 072b0d4
Add another warning
trueadm 26d6d2c
address more feedback
trueadm d058f6e
prettier
trueadm 9149b17
address nit
trueadm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
address more feedback
- Loading branch information
commit 26d6d2c203dece291f8a776c8bf799d89a1e5e5a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to have consumer proxy to context, or the other way around? Why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever we read/write from/to most. I’m actually not sure which one that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked and the context gets written to the most in our tests.