Skip to content

Deprecate context object as a consumer and add a warning message #13829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 14 commits into from
Oct 12, 2018
Merged

Deprecate context object as a consumer and add a warning message #13829

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c902bb5
Deprecate context object as a cosumer and add a warning message
trueadm Oct 11, 2018
bd3495c
change to Object.defineProperties
trueadm Oct 11, 2018
6d7d7c0
updated comments
trueadm Oct 12, 2018
773d69d
fix typo
trueadm Oct 12, 2018
22f4359
address feedback
trueadm Oct 12, 2018
e39a444
fix flow
trueadm Oct 12, 2018
40fcddb
prettier
trueadm Oct 12, 2018
4b0c8a7
Warn against Context.Consumer.Consumer
trueadm Oct 12, 2018
f174b6e
more changes based on feedback
trueadm Oct 12, 2018
59917cd
move line
trueadm Oct 12, 2018
072b0d4
Add another warning
trueadm Oct 12, 2018
26d6d2c
address more feedback
trueadm Oct 12, 2018
d058f6e
prettier
trueadm Oct 12, 2018
9149b17
address nit
trueadm Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix flow
  • Loading branch information
@trueadm
trueadm committed Oct 12, 2018
commit e39a444a3c509f06aa718c520cd68f16a05cbda1
4 changes: 2 additions & 2 deletions packages/react-reconciler/src/ReactFiberBeginWork.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ function updateContextConsumer(
// a property called "_context", which also gives us the ability to check
// in DEV mode if this property exists or not and warn if it does not.
if (__DEV__) {
if (context._context === undefined) {
if ((context: any)._context === undefined) {
if (!hasWarnedAboutUsingContextAsConsumer) {
hasWarnedAboutUsingContextAsConsumer = true;
warning(
Expand All @@ -1122,7 +1122,7 @@ function updateContextConsumer(
);
}
} else {
context = context._context;
context = (context: any)._context;
}
}
const newProps = workInProgress.pendingProps;
Expand Down