[Fizz][Float] Refactor Resources by gnoff · Pull Request #27400 · facebook/react

This change refactors the implementation of Stylesheet resources and Style tag Resources. The Style tag resource was already handled with special rules because it does not Flush is the same way as …

gnoff

committed

[Fizz][Float] Refactor Resources

gnoff

committed

Unifies the key identity of preloads and resources. Some resources do not have a loadable type and we identify these as UnknownResources. For example fonts and images are preloadable but not actual…

gnoff

committed

renames type Precedence to PrecedenceQueue to better describe what it is. A precedence is now always the string value and the precedence queue is the thing that holds info about style tag rules and…

gnoff

committed

Preloads need to be stashed during a render because they may need to be put in a different flushing queue or may need to be prevented from flushing. This only applies to a few resource types howeve…

gnoff

committed

Adds a test case to ensure that regardless of what order prelaods and resources are created there is at most one preload per resource. This affects stylesheets, scripts, and moduleScripts only

gnoff

committed

Adds a test to cover the case where you preload a stylesheet but then render a styletag with the href using precedence. This is probably done as a mistake (accidentally using the same href) but if …

gnoff

committed

Models image resources as their own type to encode the "promotion" behavior when an img tag is rendered and we promote the priority

gnoff

committed

Adds a test demonstrating preload credential transfer across prerender/resume

gnoff

committed

PrecedenceQueue -> StyleQueue

gnoff

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Fizz][Float] Refactor Resources #27400

[Fizz][Float] Refactor Resources #27400
gnoff merged 10 commits intofacebook:mainfrom
gnoff:refactor-resources

Commits on Sep 26, 2023

This change refactors the implementation of Stylesheet resources and Style tag Resources. The Style tag resource was already handled with special rules because it does not Flush is the same way as …

[Fizz][Float] Refactor Resources

Unifies the key identity of preloads and resources. Some resources do not have a loadable type and we identify these as UnknownResources. For example fonts and images are preloadable but not actual…

renames type Precedence to PrecedenceQueue to better describe what it is. A precedence is now always the string value and the precedence queue is the thing that holds info about style tag rules and…

Preloads need to be stashed during a render because they may need to be put in a different flushing queue or may need to be prevented from flushing. This only applies to a few resource types howeve…

Adds a test case to ensure that regardless of what order prelaods and resources are created there is at most one preload per resource. This affects stylesheets, scripts, and moduleScripts only

Adds a test to cover the case where you preload a stylesheet but then render a styletag with the href using precedence. This is probably done as a mistake (accidentally using the same href) but if …

Models image resources as their own type to encode the "promotion" behavior when an img tag is rendered and we promote the priority

Adds a test demonstrating preload credential transfer across prerender/resume

PrecedenceQueue -> StyleQueue

[Fizz][Float] Refactor Resources #27400gnoff merged 10 commits intofacebook:mainfacebook/react:mainfrom gnoff:refactor-resourcesgnoff/react:refactor-resourcesCopy head branch name to clipboard

Commits

Commits on Sep 26, 2023

[Fizz][Float] Refactor Resources #27400
gnoff merged 10 commits intofacebook:mainfrom
gnoff:refactor-resources