Skip to content

[Fizz][Float] Refactor Resources #27400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 26, 2023
Merged

[Fizz][Float] Refactor Resources #27400

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
204a8f7
This change refactors the implementation of Stylesheet resources and …
gnoff Sep 20, 2023
b9aeb26
[Fizz][Float] Refactor Resources
gnoff Sep 21, 2023
52fa7fa
Unifies the key identity of preloads and resources. Some resources do…
gnoff Sep 22, 2023
de72972
renames type Precedence to PrecedenceQueue to better describe what it…
gnoff Sep 22, 2023
b88f417
Preloads need to be stashed during a render because they may need to …
gnoff Sep 22, 2023
0275871
Adds a test case to ensure that regardless of what order prelaods and…
gnoff Sep 22, 2023
e78140c
Adds a test to cover the case where you preload a stylesheet but then…
gnoff Sep 22, 2023
c3a0d27
Models image resources as their own type to encode the "promotion" be…
gnoff Sep 23, 2023
c21887f
Adds a test demonstrating preload credential transfer across prerende…
gnoff Sep 23, 2023
c003f8a
PrecedenceQueue -> StyleQueue
gnoff Sep 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds a test to cover the case where you preload a stylesheet but then… 
… render a styletag with the href using precedence. This is probably done as a mistake (accidentally using the same href) but if you are going to inline on your own then you should also take care not to preload
  • Loading branch information
@gnoff
gnoff committed Sep 26, 2023
commit e78140c7080e32b7fd81e5131b3baffac944d5e6
37 changes: 37 additions & 0 deletions packages/react-dom/src/__tests__/ReactDOMFloat-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4119,6 +4119,43 @@ body {
);
});

it('should warn if you preload a stylesheet and then render a style tag with the same href', async () => {
const style = 'body { color: red; }';
function App() {
ReactDOM.preload('foo', {as: 'style'});
return (
<html>
<body>
hello
<style precedence="default" href="foo">
{style}
</style>
</body>
</html>
);
}

await expect(async () => {
await act(() => {
renderToPipeableStream(<App />).pipe(writable);
});
}).toErrorDev([
'React encountered a hoistable style tag for the same href as a preload: "foo". When using a style tag to inline styles you should not also preload it as a stylsheet.',
]);

expect(getMeaningfulChildren(document)).toEqual(
<html>
<head>
<style data-precedence="default" data-href="foo">
{style}
</style>
<link rel="preload" as="style" href="foo" />
</head>
<body>hello</body>
</html>,
);
});

it('should preload only once even if you discover a stylesheet, script, or moduleScript late', async () => {
function App() {
// We start with preinitializing some resources first
Expand Down