Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running workers, Activity task worker and Decision task worker throw an
asyncio.CancelledErrorerror the first time they are started(not sure why), in python 3.7, the retry decorator excepts that error usingexcept Exceptionand trys to restart the worker which solves the issue.In python 3.8,
asyncio.CancelledErrorbecame a subclass of BaseException instead of Exception, so the error is no longer excepted and is raised instead, causing the workers to not start.The previous commit solved this issue for the Activity task worker, but not for the Decision task worker(which failed for our case), this PR solves both issues by adding handling of the
asyncio.CancelledErrorerror to the retry decoratorso that it would behave exactly as it did in python 3.7.Handling of
asyncio.CancelledErroris separated from handling ofExceptionto not calllogger.error().