Skip to content

Py310 fix #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 31, 2022
Merged

Py310 fix #6

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78f1c73
Revert "add activity loop retry"
malkaed May 26, 2022
7c5a858
added asyncio.CancelledError to retry exception handling
malkaed May 26, 2022
72fe8b0
sepereated CancelledError from normal Exception in retry decorator
malkaed May 27, 2022
cf3458b
minor syntax update
malkaed May 27, 2022
8afeefb
catch gaierror exception as well
NullOsama May 30, 2022
0d588b0
Merge pull request #7 from fastfishio/NullOsama-patch-1
malkaed May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
sepereated CancelledError from normal Exception in retry decorator
  • Loading branch information
@malkaed
malkaed committed May 27, 2022
commit 72fe8b0dd23d5138027f3235ca362a439a9fc156
5 changes: 4 additions & 1 deletion temporal/retry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ async def retry_loop(*args, **kwargs):
await fp(*args, **kwargs)
logger.debug("@retry decorated function %s exited, ending retry loop", fp.__name__)
break
except (Exception, asyncio.CancelledError) as ex:
except asyncio.CancelledError as ex:
logger.info("%s raised CancelledError, retrying...", fp.__name__)
await asyncio.sleep(INITIAL_DELAY_SECONDS)
except Exception as ex:
now = calendar.timegm(time.gmtime())
if last_failed_time == -1 or (now - last_failed_time) > RESET_DELAY_AFTER_SECONDS:
delay_seconds = INITIAL_DELAY_SECONDS
Expand Down