Skip to content

Conversation

@hiranya911
Copy link
Contributor

Implementing the new APIs for sending messages in batches:

BatchResponse sendAll(List<Message>)
BatchResponse sendAll(List<Message>, boolean)
BatchResponse sendMulticast(MulticastMessage)
BatchResponse sendMulticast(MulticastMessage, boolean)

go/fcm-multicast for the full proposal.

Also implementing the following refactorings for clarity and modularity:

  • Reducing the size of and responsibilities of FirebaseMessaging by introducing 2 new classes - FirebaseMessagingClient and InstanceIdClient.
  • All the rpc logic is now implemented in the new classes, and FirebaseMessaging is just the public API for them.
  • Moved some of the common API client logic to a new ApiClientUtils class, so we can share it across packages in the future.

@hiranya911 hiranya911 assigned hiranya911 and unassigned chong-shao Feb 11, 2019
@hiranya911 hiranya911 merged commit e19ca29 into master Mar 14, 2019
@hiranya911 hiranya911 deleted the hkj-fcm-batch branch March 14, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants