Setting the X-Client-Version header for FCM #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-shao
approved these changes
Feb 22, 2019
hiranya911
added a commit
that referenced
this pull request
Mar 14, 2019
* Preliminary impl of FCM batch support * Added BatchMessage class and tests * Refactored the FCM send operation * Added unit tests for sendBatch() API * Refactored error handling * Refactored FCM logic into a new FirebaseMessagingClient class * Using a separate request factory for child requests * Added the InstanceIdClient class for handling topic mgt ops * Added license headers * Renamed BatchResponse as SendResponse * Added BatchResponse class; Renamed BatchMessage to MulticastMessage * Updated tests and docs * Updated documentation * Added documentation and tests * Updated docs, changelog and annotations * Updated integration test to use multiple topics; Updated docs * Removing a redundant whitespace * Reduced FCM batch size to 100 (#250) * Setting the X-Client-Version header for FCM (#252) * Snippets for FCM sendAll() and sendMulticast() (#249) * Snippets for FCM sendAll() and sendMulticast() * Reduced batch size to 100 in snippets * Addressing some documentation nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the
X-Client-Versionheader for FCM requests. When sending batch requests, each of the child messages will carry the header.