-
Notifications
You must be signed in to change notification settings - Fork 407
Making it possible to run integration tests against any Firebase project #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Making it possible to run integration tests againsty any Firebase pro…
…ject
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,48 @@ var successCount = 0; | |
| var failure = chalk.red; | ||
| var success = chalk.green; | ||
|
|
||
| var serviceAccount; | ||
|
|
||
| try { | ||
| serviceAccount = require('../resources/key.json'); | ||
| } catch(error) { | ||
| console.log(chalk.red( | ||
| 'The integration test suite requires a service account key JSON file for a ' + | ||
| 'Firebase project to be saved to `test/resources/key.json`.', | ||
| error | ||
| )); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| var apiKey = process.argv[2]; | ||
| if (apiKey == undefined) { | ||
| console.log(chalk.red( | ||
| 'The integration test suite requires a API key for a ' + | ||
| 'Firebase project to be specified as a command-line argument.')); | ||
| process.exit(1); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the service account credential used for runnnig integration tests. | ||
| * | ||
| * @return {Object} A service account credential. | ||
| */ | ||
| function getCredential() { | ||
| return serviceAccount; | ||
| } | ||
|
|
||
| /** | ||
| * Returns the ID of the project the integration tests are executed against. | ||
| * | ||
| * @return {string} A project ID. | ||
| */ | ||
| function getProjectId() { | ||
| return serviceAccount.project_id; | ||
| } | ||
|
|
||
| function getApiKey() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: add javadoc for this function like you did for the ones above.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
| return apiKey; | ||
| } | ||
|
|
||
| /** | ||
| * Logs a message to the console in green text. | ||
|
|
@@ -125,5 +167,8 @@ module.exports = { | |
| logFailure: logFailure, | ||
| logSuccess: logSuccess, | ||
| logResults: logResults, | ||
| generateRandomString: generateRandomString | ||
| generateRandomString: generateRandomString, | ||
| getCredential: getCredential, | ||
| getProjectId: getProjectId, | ||
| getApiKey: getApiKey | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typeof apiKey === 'undefined'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done