Skip to content

Making it possible to run integration tests against any Firebase project #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2017
Merged

Making it possible to run integration tests against any Firebase project #22

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c8c4fa
Making it possible to run integration tests againsty any Firebase pro…
May 9, 2017
9739034
Added method comment; Better check for API key argument
May 11, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added method comment; Better check for API key argument
  • Loading branch information
Hiranya Jayathilaka committed May 11, 2017
commit 97390342f704e4f8b1648f078d93d811fa39c170
9 changes: 7 additions & 2 deletions test/integration/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ try {
}

var apiKey = process.argv[2];
if (apiKey == undefined) {
if (typeof apiKey === 'undefined') {
console.log(chalk.red(
'The integration test suite requires a API key for a ' +
'The integration test suite requires an API key for a ' +
'Firebase project to be specified as a command-line argument.'));
process.exit(1);
}
Expand All @@ -62,6 +62,11 @@ function getProjectId() {
return serviceAccount.project_id;
}

/**
* Returns the API key of the project the integration tests are executed against.
*
* @return {string} A Firebase API key.
*/
function getApiKey() {
Copy link
Contributor

@bojeil-google bojeil-google May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add javadoc for this function like you did for the ones above.

Copy link
Contributor Author

@hiranya911 hiranya911 May 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

return apiKey;
}
Expand Down